Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI seems skipping cgroupv2 with rootless (systemd) #2942

Closed
AkihiroSuda opened this issue May 6, 2021 · 4 comments · Fixed by #2944
Closed

CI seems skipping cgroupv2 with rootless (systemd) #2942

AkihiroSuda opened this issue May 6, 2021 · 4 comments · Fixed by #2944

Comments

@AkihiroSuda
Copy link
Member

image
https://github.com/opencontainers/runc/runs/2512206353

skip "test requires $var"

Most tests in cgroupv2 with rootless (systemd) seem skipped.

This is not a recent regression. The log from February has the same skip output. https://github.com/opencontainers/runc/runs/1867231647?check_suite_focus=true

@AkihiroSuda
Copy link
Member Author

cc @kolyshkin

@kolyshkin
Copy link
Contributor

Good catch, working on a fix

@kolyshkin
Copy link
Contributor

Hmm, we're not in a very bad shape, the previously skipped tests only found 1 bug. PTAL #2944.

@AkihiroSuda
Copy link
Member Author

Thanks for fixing! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants