Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent IO stats Op values between cgroup v1 and v2 #2964

Closed
iyashu opened this issue May 26, 2021 · 2 comments · Fixed by #2965
Closed

Inconsistent IO stats Op values between cgroup v1 and v2 #2964

iyashu opened this issue May 26, 2021 · 2 comments · Fixed by #2965
Milestone

Comments

@iyashu
Copy link
Contributor

iyashu commented May 26, 2021

We use libcontainer cgroup library GetStats api in cadvisor to fetch the usage stats for a given cgroup set. But it turns out that cgroup v2 implementation of cgroup manager GetStats api provides blkio stats with lower case Op keys under BlkioStatEntry as compare to cgroup v1. For instance, in cgroup v1, we get Op = Write for IoServiceBytesRecursive under BlkioStats, while in cgroup v2, we get Op = write (lower w case) for same stat. See this to know about how BlkioStatEntry get populated in cg1 as compare to cg2.

Does it make sense to change Op value to capitalized case Read and Write similar to cgroup v1? If yes, I can create a pull request with the fix.

Original cAdvisor Issue - google/cadvisor#2881

@dims
Copy link
Contributor

dims commented May 27, 2021

cc @mrunalp @AkihiroSuda

@AkihiroSuda
Copy link
Member

Capitalizing SGTM

@AkihiroSuda AkihiroSuda added this to the 1.0.0 milestone May 27, 2021
@cyphar cyphar mentioned this issue Jun 1, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants