Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.1.0 #3195

Closed
kolyshkin opened this issue Sep 2, 2021 · 20 comments
Closed

Release 1.1.0 #3195

kolyshkin opened this issue Sep 2, 2021 · 20 comments
Milestone

Comments

@kolyshkin
Copy link
Contributor

kolyshkin commented Sep 2, 2021

Release milestone: https://github.com/opencontainers/runc/milestone/12.

For proposed changelog, see #3320

@kolyshkin kolyshkin added this to the 1.1.0 milestone Sep 2, 2021
@AkihiroSuda
Copy link
Member

Proposed release date: Sep 13 2021 (which is dangerously close).

I think we should release RC1 by Sep 13, and GA by the end of the month.

@cyphar
Copy link
Member

cyphar commented Sep 2, 2021

For the record, the milestone date isn't set in stone -- I set them based on a ~3 month release timeline. We can delay it if there's critical stuff we want to get in (or we can remove things from the 1.1 milestone that can wait).

@kolyshkin
Copy link
Contributor Author

I agree with @AkihiroSuda -- let's try to merge most PRs we want to merge and have an rc1 out by Sep 13.

@cyphar
Copy link
Member

cyphar commented Sep 9, 2021

I've reviewed and merged the smaller ones. #2576 and #3131 are the two big ones that I'll need to take a long look at. #3068 seems to be still waiting on rhatdan's opinion on the naming of the option (I threw in my 2c for what it's worth).

@kolyshkin
Copy link
Contributor Author

OK, we only have 3 PRs left, and I hope we can do an 1.1.0-rc1 this week.

@kolyshkin
Copy link
Contributor Author

OK, only two PRs left, each with a single LGTM

PTAL @opencontainers/runc-maintainers 🙏🏻

@cyphar
Copy link
Member

cyphar commented Dec 8, 2021

Is all we need, both with a single LGTM. I will set up the 1.1-rc1 PR after they're merged.

@kolyshkin
Copy link
Contributor Author

Assembled a changelog based on PRs with 1.1 milestone

@cyphar
Copy link
Member

cyphar commented Dec 13, 2021

@kolyshkin Did you want me to take anything from this changelog into #3320?

@kolyshkin
Copy link
Contributor Author

@kolyshkin Did you want me to take anything from this changelog into #3320?

Nope; I have already cross-checked it against #3320 and left some suggestions, so this one is now obsoleted; I'll remove it.

@cyphar
Copy link
Member

cyphar commented Dec 14, 2021

Great, thanks. Will send the 1.1-rc1 PR in a little bit.

@kolyshkin
Copy link
Contributor Author

OK I am testing this in kubernetes and cadvisor.

In particular, it seems that changes to cgroups start to pay off, I was able to simplify some of the kubelet/cm code.

@thaJeztah
Copy link
Member

(binary-only) updates in containerd and moby:

@kolyshkin
Copy link
Contributor Author

kolyshkin commented Dec 15, 2021

@AkihiroSuda
Copy link
Member

What do we need toward v1.1 GA?

@cyphar
Copy link
Member

cyphar commented Dec 17, 2021

Nothing specific, I don't know how long we want to wait for serious bug reports to come in. If we want to do a release soon I'm game. I'm on PTO next week, so I can set up a release PR at the start of January.

@kolyshkin
Copy link
Contributor Author

From my side, I need to finish kubernetes/kubernetes#107016 and I currently don't have time; hope to continue next week.

@kolyshkin
Copy link
Contributor Author

From my side, I need to finish kubernetes/kubernetes#107016 and I currently don't have time; hope to continue next week.

OK, this is now ready (as kubernetes/kubernetes#107149), and although there are a few issues left unsolved (such as using manager.Exists() with SkipDevices set), those are to be solved in later releases (e.g. 1.2).

From my perspective, runc 1.1 is good to go. // Cc @cyphar @AkihiroSuda

@cyphar
Copy link
Member

cyphar commented Jan 14, 2022

#3338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants