Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some questions about error handling on runc, crun or other runtime #1061

Open
payall4u opened this issue Aug 5, 2020 · 4 comments
Open

Some questions about error handling on runc, crun or other runtime #1061

payall4u opened this issue Aug 5, 2020 · 4 comments
Labels

Comments

@payall4u
Copy link

payall4u commented Aug 5, 2020

Runc and crun will go different error message when delete a non-existent container, such as:
runc got container <container-id> does not exist
crun got error opening file 'container-status': No such file or directory\n: unknown"
But containerd and shim will identify these errors by error message. Some runc error can be recognized and handle correctly, but crun can't.
We already have a lot runtime tools, and containerd-shim-v2 can be used with any runtime tools. Should error messages of them be standardized?

@payall4u payall4u changed the title Some questions about error handling on runc Some questions about error handling on runc, crun or other runtime Aug 5, 2020
@giuseppe
Copy link
Member

giuseppe commented Aug 6, 2020

maybe we could at least agree on a few exit codes so that container engines don't have to parse the error string.

@cyphar
Copy link
Member

cyphar commented Nov 1, 2020

I agree that standardising some basic exit codes would be a good idea.

@utam0k
Copy link
Member

utam0k commented Aug 25, 2022

@giuseppe @cyphar @AkihiroSuda
What is the status of this issue? I have interested in this. This is a good idea!

@utam0k
Copy link
Member

utam0k commented Aug 25, 2022

How about simply adding 255 to the error code if there is an error inside OCI Runtime? It would be easier for the client to handle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants