Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update your vendored copy of hashicorp-multierror #677

Closed
elboulangero opened this issue Jan 14, 2019 · 1 comment
Closed

Please update your vendored copy of hashicorp-multierror #677

elboulangero opened this issue Jan 14, 2019 · 1 comment

Comments

@elboulangero
Copy link

Hashicorp released multierror version 1.0 on Aug. 2018.

In Debian, we're building runtime-tools against this version of multierror. There's only a little patch to apply to runtime-tools make it work:

--- a/validate/validate_test.go
+++ b/validate/validate_test.go
@@ -716,11 +716,11 @@
 	}{
 		{
 			config: &rspec.Spec{},
-			error:  "1 error occurred:\n\n* 'Spec.Version' should not be empty",
+			error:  "1 error occurred:\n\t* 'Spec.Version' should not be empty\n\n",
 		},
 		{
 			config: nil,
-			error:  "1 error occurred:\n\n* Spec can't be nil",
+			error:  "1 error occurred:\n\t* Spec can't be nil\n\n",
 		},
 		{
 			config: &rspec.Spec{
@@ -733,7 +733,7 @@
 				Version: "1.0.0",
 				Root:    &rspec.Root{},
 			},
-			error: "1 error occurred:\n\n* 'Root.Path' should not be empty",
+			error: "1 error occurred:\n\t* 'Root.Path' should not be empty\n\n",
 		},
 	} {
 		t.Run(tt.error, func(t *testing.T) {
@zhouhao3
Copy link

A corresponding modification was made in #678. Thank you for your suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants