Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpack: useless config.json #13

Closed
cyphar opened this issue Nov 6, 2016 · 1 comment
Closed

unpack: useless config.json #13

cyphar opened this issue Nov 6, 2016 · 1 comment
Milestone

Comments

@cyphar
Copy link
Member

cyphar commented Nov 6, 2016

The config.json generated when unpacking is not useful because it is a config for running in the host, which isn't helpful. While this can be corrected by a user (using oci-runtime-tools generate) this quite a bit of a pain.

The best choice IMO would be to create a library that can take a v1.Image and then apply it to a runtime-tools/generate.Generator. We can then use the default config for runC as the base (which we know is actually sane).

The upstream bug for this is opencontainers/image-tools#76 but we should implement this ourselves.

@cyphar
Copy link
Member Author

cyphar commented Nov 6, 2016

This has been fixed in 3c4ef3f and 43efb56. Though we need to re-implement everything locally (this is just a hack).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant