Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exception on Windows: NotImplementedError: c #62

Open
pcoccoli opened this issue Jul 21, 2022 · 0 comments
Open

exception on Windows: NotImplementedError: c #62

pcoccoli opened this issue Jul 21, 2022 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@pcoccoli
Copy link
Collaborator

Reported by user on Windows.

File "C:\Users\redacted\pyenv\redacted\lib\site-packages\firepit\__init__.py", line 30, in get_storage
   raise NotImplementedError(url.scheme)
NotImplementedError: c

I think what happened here is that a Windows path was passed in as the url to get_storage. The urlparse looks at it and thinks c is the "scheme" but we only support "" or "postgresql". We could add some code to try and detect a Windows path and then skip urlparse.

@pcoccoli pcoccoli added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant