Swapped x,y coords in GDAL3 case

[Kirill888]

I know it's not merged yet, but I saw this code in Slack, and pretty sure this bit is wrong:

cube-in-a-box/scripts/ls_public_bucket.py

Line 176 in 5ea202f

y, x, z = t.TransformPoint(p[1], p[0])

Should be

    x, y, z = t.TransformPoint(p[1], p[0]) 

order of projected coordinates is typically not swapped by CRS definition.

Also I would strongly suggest extracting and labeling lon/lat from p rather than using index based access, something like this up top: lon, lat = p, as this then clearly communicates the expected order of coordinates on input to the transform function.

[alexgleith]

Yeah, you're right.

Here's the working code:

        lon, lat = p
        # GDAL 3 reverses coordinate order, because... standards
        if LON_LAT_ORDER:
            # GDAL 2.0 order
            x, y, z = t.TransformPoint(lon, lat)
        else:
            # GDAL 3.0 order
            x, y, z = t.TransformPoint(lat, lon)

        return [x, y]

Notes from here: OSGeo/gdal#1546

And an output projected extent that was tested.