Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odc-geo repo? #58

Closed
snowman2 opened this issue Jun 18, 2020 · 6 comments
Closed

odc-geo repo? #58

snowman2 opened this issue Jun 18, 2020 · 6 comments

Comments

@snowman2
Copy link

Thoughts on moving geospatial tools to a separate package/repository (maybe odc-geo)?

Maybe combine:

  1. opendatacube-core geobox functionality
  2. reprojection utilities here: https://github.com/opendatacube/odc-tools/blob/develop/libs/algo/odc/algo/_warp.py
  3. Other?

This would be useful for the geospatial xarray community. For example, the geobox stuff is used in geocube and the dask supported reprojection stuff would be a nice engine to use in rioxarray.

@Kirill888
Copy link
Member

Kirill888 commented Jun 19, 2020

In general I agree Alan. I think moving some of the lower level functionality into a separate library will benefit datacube users as well as allowing easier re-use by other projects in geospatial space. We might even get larger contributor base for "simpler library" without all the database hurdle that new users of datacube need to deal with.

It will be a significant refactor and will take quite a bit of developer time, so this is not something I can commit to on my own. I will raise this proposal with members of ODC Steering Council. And while I do not expect resistance to this proposal, I do expect that it won't happen quickly, as there are currently some high-priority tasks that won't be finished soon. We can probably justify including this in ODC 2.0 work.

On a technical level this will involve moving geometry and xarray related utilities out of datacube-core into a stand-alone library, then moving some of the odc-tools libraries there as well. Tests will need to move as well, new tests might need to be written as I won't be surprised if some of the coverage comes from integration tests rather than unit-tests. Various utilities used by those tests will need to be moved too. Ideally I would like to keep commit history as well. So it's a sizeable amount of work to undertake, and probably best done by folks already familiar with the current codebase.

pinging some ODC people for visibility:

@alexgleith @woodcockr @gamedaygeorge @GypsyBojangles

@Kirill888
Copy link
Member

@RichardScottOZ
Copy link
Contributor

Thanks Kirill.

@Kirill888
Copy link
Member

Work starting here: https://github.com/opendatacube/odc-geo

@snowman2
Copy link
Author

snowman2 commented Apr 4, 2022

Thanks @Kirill888 👍

@snowman2 snowman2 closed this as completed Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants