Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Add support for deploying a gitea instance as a make target #116

Closed
2 tasks
LaVLaS opened this issue Oct 3, 2023 · 3 comments · Fixed by #154
Closed
2 tasks

Makefile: Add support for deploying a gitea instance as a make target #116

LaVLaS opened this issue Oct 3, 2023 · 3 comments · Fixed by #154
Labels
good first issue Good for newcomers kind/enhancement New feature or request priority/normal An issue with the product; fix when possible

Comments

@LaVLaS
Copy link
Contributor

LaVLaS commented Oct 3, 2023

Currently the steps to deploy a gitea instance is outlined in the README (#30) but there is no controlled way to deploy it using automation. We should move these steps to the Makefile so that we can ensure that the gitea instance is uniform and known across any deployment in all environments.

This Makefile target should also be documented as part of #110

Expected workflow:

  1. Provision Cluster
  2. Run make deploy-gitea
  3. Fork github/opendatahub-io/ai-edge -- gitea/edge-user/ai-edge
  4. Update gitea/edge-user/ai-edge to point to this gitea server instance
  5. Install ACM
  6. Run ACM registration that points to our gitea server
  • Add deployment of the gitea-operator catalogsource and subscription to a Makefile target
  • Add creation of the Gitea custom resource as a separate target
@adelton
Copy link
Contributor

adelton commented Oct 6, 2023

As also discussed in #129 -- it is not clear why Gitea is needed at all, rather than optional. But if it is needed (and even if it is optional), it needs to be in place when the GitOps pipeline runs, otherwise that pipeline run won't be able to file a proper pull request to update the container image SHA-256 to the newly built and pushed one.

@adelton
Copy link
Contributor

adelton commented Oct 25, 2023

Hmm, this was closed via #154 but that does not touch any Makefile at all.

Should this issue be kept open? Or is it closed with "current approach is good enough"?

@LaVLaS
Copy link
Contributor Author

LaVLaS commented Oct 26, 2023

For the record, originally I was going to add a makefile target to deploy gitea when i created the initial PR but decided against it until we added a capability that specifically targeted or required testing against gitea. Right now, there is a link to the gitea/README.md which I feel is sufficient for now if anyone wants to utilize gitea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/enhancement New feature or request priority/normal An issue with the product; fix when possible
Projects
Status: No status
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants