Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[P0] Update KServe e2e #5

Closed
heyselbi opened this issue Jun 19, 2023 · 4 comments · Fixed by #39
Closed

[P0] Update KServe e2e #5

heyselbi opened this issue Jun 19, 2023 · 4 comments · Fixed by #39
Assignees
@israel-hdez
Labels
kind/enhancement Enhancement to current features odh-release/1.8 Need to do for ODH Release v1.8.0
Milestone
Watsonx.ai Readin...

Comments

@heyselbi
Copy link

heyselbi commented Jun 19, 2023 •
edited by taneem-ibrahim
Loading

Port the e2e test suite for upstream KServe on OpenShift.
@heyselbi heyselbi converted this from a draft issue Jun 19, 2023
@heyselbi heyselbi changed the title Update KServe e2e [P0] Update KServe e2e Jun 19, 2023
@heyselbi heyselbi mentioned this issue Jun 20, 2023
Closed
@heyselbi heyselbi added the kind/enhancement Enhancement to current features label Jun 22, 2023
@heyselbi heyselbi moved this from Backlog to To-do This Sprint in ODH Model Serving Planning Jun 22, 2023
@heyselbi heyselbi moved this from To-do This Sprint to Backlog in ODH Model Serving Planning Jun 22, 2023
@israel-hdez israel-hdez mentioned this issue Jul 10, 2023
Merged
@heyselbi
Copy link
Author

@danielezonca could we provide more details here?

@taneem-ibrahim taneem-ibrahim moved this from Backlog to Groomed Issues in ODH Model Serving Planning Jul 13, 2023
@skonto skonto mentioned this issue Jul 17, 2023
Closed
@israel-hdez israel-hdez self-assigned this Jul 18, 2023
@israel-hdez israel-hdez moved this from Groomed Issues to In Progress in ODH Model Serving Planning Jul 18, 2023
@heyselbi heyselbi modified the milestones: Watsonx.ai: Onboarding of KServe/Caikit/TGIS into ODH, Watsonx.ai Readiness for ODH 1.8.0 Release Jul 19, 2023
@heyselbi heyselbi added the odh-release/1.8 Need to do for ODH Release v1.8.0 label Jul 19, 2023
@israel-hdez
Copy link

So far, what I've learnt:

  • E2E tests are here: https://github.com/opendatahub-io/kserve/tree/master/test/e2e
  • E2E tests rely on some serving runtimes to be configured. Most notably, one that supports sklearn models, but other runtimes are also used. So, despite we won't support any at the beginning, we may need them to run E2Es.
  • Just by quickly scanning over the file names, looks like a lot of those E2E tests are over things/features that we are not supporting on our initial KServe adoption. Maybe we will end up with a very small set.
  • E2Es fail miserably, because they use the URL set at the InferenceService, which is incorrect for the OpenShift case.

@israel-hdez israel-hdez mentioned this issue Jul 25, 2023
Merged
@heyselbi
Copy link
Author

Relevant PRs by @israel-hdez
#39 and openshift/release#41610

@heyselbi heyselbi linked a pull request Jul 26, 2023 that will close this issue
Openshift-ci onboarding #39
Merged
@israel-hdez israel-hdez mentioned this issue Jul 27, 2023
Merged
@heyselbi
Copy link
Author

@israel-hdez : openshift-ci tests are passing

@github-project-automation github-project-automation bot moved this from In Progress to Done in ODH Model Serving Planning Aug 1, 2023
israel-hdez referenced this issue in israel-hdez/kserve Aug 15, 2023
@vaibhavjainwiz
Merge pull request #5 from vajain-rhods/add_setup_cfg
b464358 
Add name and version in setup.cfg file to support CPaaS
Jooho referenced this issue in Jooho/kserve Jan 11, 2024
@Xaenalt
Merge pull request #5 from Xaenalt:main
5e429a4 
Remove explicit sha256 from dockerfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@israel-hdez israel-hdez

Labels
kind/enhancement Enhancement to current features odh-release/1.8 Need to do for ODH Release v1.8.0
Projects
Internal tracking
Status: No status
ODH Feature Tracking
Status: No status
ODH Model Serving Planning
Status: Done
Milestone
Watsonx.ai Readiness for ODH 1.8.0 Re...
Development

Successfully merging a pull request may close this issue.

Openshift-ci onboarding israel-hdez/kserve
2 participants
@israel-hdez @heyselbi