Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate the following tests, so we can get them done more easily every time #441

Open
jiridanek opened this issue Nov 6, 2024 · 0 comments
Assignees

Comments

@jiridanek
Copy link
Member

          I did the following test:
  • Created a notebook using the original image of the odh-notebook-controller before your changes.
    • notebook-b1 created at Nov 6, 2024, 11:35 AM
    • image: 'registry.redhat.io/openshift4/ose-oauth-proxy@sha256:4bef31eb993feb6f1096b51b4876c65a6fb1f4401fee97fa4f4542b6b7c9bc46'
  • Changed odh-notebook-controller image to include your changes.
    • quay.io/opendatahub/odh-notebook-controller:pr-437
    • Created a new notebook-a1 at Nov 6, 2024, 11:41 AM
  • Updated the oauth proxy image to on the odh-notebook-controller deployment to registry.redhat.io/openshift4/ose-oauth-proxy@sha256:4f8d66597feeb32bb18699326029f9a71a5aca4a57679d636b876377c2e95695
  • Check if any notebook has been affected
    • Nothing change so far on the old deployed notebooks
  • Created a new notebook and check the assigned oauth
    • c1 created at Nov 6, 2024, 11:46 AM
    • It has the new oauth image
    • The rest notebooks didn't get any restarts
  • Till write you this message at 12.02pm nothing has changed on the notebooks
  • One additional check was to restart the b1 and a1 notebooks and see if the oauthproxy image has been changed and it didn't which is good sign

So I would say /lgtm

Originally posted by @atheo89 in #437 (comment)

@jiridanek jiridanek self-assigned this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant