Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the test notebooks for the 2023b release #192

Closed
1 of 3 tasks
Tracked by #163
atheo89 opened this issue Aug 31, 2023 · 5 comments
Closed
1 of 3 tasks
Tracked by #163

Update the test notebooks for the 2023b release #192

atheo89 opened this issue Aug 31, 2023 · 5 comments
Assignees
Labels
kind/feature New feature or request priority/normal An issue with the product; fix when possible
Milestone

Comments

@atheo89
Copy link
Member

atheo89 commented Aug 31, 2023

Update the test notebooks for the 2023b release

Target branch: 2023b

Depends-On: #178

Acceptance criteria

  • Update the test with respect to the notebook package versions. link
  • Update the makefile with the commands.
  • Update the GH workflow/Ocp CI.

Reference: #178

@github-project-automation github-project-automation bot moved this to 📋 Backlog in ODH IDE Planning Aug 31, 2023
@atheo89 atheo89 added this to the 2023b milestone Aug 31, 2023
@harshad16 harshad16 added kind/feature New feature or request priority/normal An issue with the product; fix when possible labels Sep 7, 2023
@harshad16 harshad16 moved this from 📋 Backlog to 🔖Todo in ODH IDE Planning Oct 6, 2023
@dibryant
Copy link
Contributor

All of the notebook test look good and up to date with the correct package versions. Updating the make file a pull request will be opened for that.

@dibryant
Copy link
Contributor

Makefile was updated and looks good!

@atheo89
Copy link
Member Author

atheo89 commented Oct 24, 2023

All of the notebook test look good and up to date with the correct package versions. Updating the make file a pull request will be opened for that.

Hey Diamond, could you kindly perform a thorough review of the package versions currently present in our test notebooks on the main branch? I've noticed that after syncing from the 2023b to the main branch, there have been some changes.

For instance, I've observed that the minimal (ubi8 & 9) definitely requires an update. It currently specifies jupyter_version 3.5 (link), but we have actually transitioned to version 3.6. You can find the details in the pipfile. Accordingly for the rest.

@dibryant
Copy link
Contributor

All of the notebook test look good and up to date with the correct package versions. Updating the make file a pull request will be opened for that.

Hey Diamond, could you kindly perform a thorough review of the package versions currently present in our test notebooks on the main branch? I've noticed that after syncing from the 2023b to the main branch, there have been some changes.

For instance, I've observed that the minimal (ubi8 & 9) definitely requires an update. It currently specifies jupyter_version 3.5 (link), but we have actually transitioned to version 3.6. You can find the details in the pipfile. Accordingly for the rest.

Will look into this must've just changed thank you!

@harshad16
Copy link
Member

Thanks for working on this.
Marking this as complete.
Closing the issue.

@github-project-automation github-project-automation bot moved this from 🔖Todo to ✅Done in ODH IDE Planning Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request priority/normal An issue with the product; fix when possible
Projects
Status: Done
Status: No status
Archived in project
Development

No branches or pull requests

3 participants