Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threshold violation alerting #1158

Closed
alexcreasy opened this issue Apr 20, 2023 · 3 comments
Closed

Threshold violation alerting #1158

alexcreasy opened this issue Apr 20, 2023 · 3 comments
Labels
feature/model-serving Model Serving Feature priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.

Comments

@alexcreasy
Copy link
Contributor

alexcreasy commented Apr 20, 2023

Goal

Clearly display threshold violations to the user

Dependency issue

Itemized goals

  • Create subtasks when mocks available

Aspects continued elsewhere

No response

Mocks

Mocks not yet available, ticket subject to rework on receipt.

@alexcreasy alexcreasy added the priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. label Apr 20, 2023
@github-project-automation github-project-automation bot moved this to Needs prioritization in ODH Dashboard Planning Apr 20, 2023
@alexcreasy alexcreasy added the feature/model-serving Model Serving Feature label Apr 20, 2023
@alexcreasy alexcreasy added this to the Explainability Phase 1 milestone Apr 20, 2023
@Gkrumbach07 Gkrumbach07 moved this from Needs prioritization to To do in ODH Dashboard Planning Apr 25, 2023
@alexcreasy
Copy link
Contributor Author

@vconzola @kywalker-rh this ticket was based on the original requirements doc Karl sent round - I've noticed we don't really have anything in the current set of mocks around this - is this something you're planning to add, or does the graph simply exceeding the threshold line serve this purpose?

@vconzola
Copy link

vconzola commented May 19, 2023

@alexcreasy yes, the text of the issue doesn't say anything about alerting users, so i consider just showing the graph exceeding the threshold satisfying this requirement. i kinda recall Rob or Karl saying something about changing the line color for values that exceed the threshold, but for me that's a nice to have if it's easy to do.

@alexcreasy
Copy link
Contributor Author

@vconzola ok thanks for that, I'll close this issue in that case as the phase 1 requirement was already met at phase 0.

@alexcreasy alexcreasy closed this as not planned Won't fix, can't repro, duplicate, stale May 22, 2023
@github-project-automation github-project-automation bot moved this from To do to Done in ODH Dashboard Planning May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/model-serving Model Serving Feature priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.
Projects
No open projects
Archived in project
Development

No branches or pull requests

2 participants