Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deletion of metric registrations #1162

Closed
alexcreasy opened this issue Apr 20, 2023 · 3 comments · Fixed by #1343
Closed

Deletion of metric registrations #1162

alexcreasy opened this issue Apr 20, 2023 · 3 comments · Fixed by #1343
Assignees
Labels
feature/model-serving Model Serving Feature priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.

Comments

@alexcreasy
Copy link
Contributor

alexcreasy commented Apr 20, 2023

Goal

The user should be able to delete previously defined metric registrations

Dependency issue

Itemized goals

  • On the bias metric configuration page, add a delete button to the table row actions kebab
  • The delete button should get the user to confirm deletion using the standard flow, and then call the TrustyAI API to delete the bias configuration.

Aspects continued elsewhere

No response

Mocks

78888c5a-a824-42eb-96b2-c4f77c89cd8a

@alexcreasy alexcreasy added priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. feature/model-serving Model Serving Feature labels Apr 20, 2023
@alexcreasy alexcreasy added this to the Explainability Phase 1 milestone Apr 20, 2023
@github-project-automation github-project-automation bot moved this to Needs prioritization in ODH Dashboard Planning Apr 20, 2023
@Gkrumbach07 Gkrumbach07 moved this from Needs prioritization to To do in ODH Dashboard Planning Apr 25, 2023
@alexcreasy alexcreasy changed the title [SPIKE] Deletion of metric registrations [DRAFT] Deletion of metric registrations May 22, 2023
@alexcreasy
Copy link
Contributor Author

@vconzola @kywalker-rh just FYI there's nothing specific around this flow in the mocks. Do we just go with a confirmation that requires the user to type the name of the metric to delete?

@vconzola
Copy link

Yes. That would be consistent with the rest of the UI. Also, we haven't typically been mocking up these types of flows, but I'm happy to do it if there are other ones like this you want to see mocks for.

@alexcreasy
Copy link
Contributor Author

Thanks for that Vince, I don't think that needs a mockup to be honest, I just wanted to be sure you were on board with the "standard" flow we already have.

@alexcreasy alexcreasy changed the title [DRAFT] Deletion of metric registrations Deletion of metric registrations Jun 5, 2023
@alexcreasy alexcreasy moved this from To do to In progress in ODH Dashboard Planning Jun 8, 2023
@alexcreasy alexcreasy linked a pull request Jun 8, 2023 that will close this issue
6 tasks
@github-project-automation github-project-automation bot moved this from In progress to Done in ODH Dashboard Planning Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/model-serving Model Serving Feature priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants