Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure bias metric form #1274

Closed
alexcreasy opened this issue May 22, 2023 · 1 comment · Fixed by #1343
Closed

Configure bias metric form #1274

alexcreasy opened this issue May 22, 2023 · 1 comment · Fixed by #1343
Assignees
Labels
feature/model-serving Model Serving Feature priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.

Comments

@alexcreasy
Copy link
Contributor

alexcreasy commented May 22, 2023

Goal

Implement functionality allowing a user to create and update a bias metric configuration

Dependency issue

Itemized goals

  • Implement the configure bias metric modal shown in mocks i and ii, remembering that a user will need to be able to both create a new and update an existing bias metric configuration – therefore design in a flexible way that maximises code reuse.
  • Add validation as described on the mock
  • Closing the modal via the X or cancel button should behave as described in the mocks
  • When the user clicks configure:
    • Send values to trustyai service to create / update the bias metric config
      • On Success: Close modal, remain on the configure bias metric screen and update the list of configured metrics.
      • On Error: functionality TBD.
  • Add logic to the following buttons in the UI to start configuring a new bias metric (i.e. navigate to metrics configuration screen with open modal):
    • Mock iii - ‘Configure’ button on empty state of model bias screen.
    • Mock iv - ‘Configure metric’ button on bias metric configuration list view
    • Mock v - ‘Configure’ button on the info tip of the Deployed models screen.
  • Add update logic:
    • On the bias metric configuration list view, the table row actions kebab should have an update action (See mock vi for reference).
    • When this is clicked the ‘Configure bias metric model’ should be opened and pre-populated with existing values of the ‘bias metric’ for the user to edit.
    • When the user submits, send an update request to the trustyai service.
    • Follow the same post-submit routine as for bias metric creation.

Aspects continued elsewhere

  • Default violation thresholds will be specific for each “metric type” – to be supplied.

Mocks

i)
a1dfb24d-b4af-469a-a67a-146a400b6f38
ii)
0fd40fc7-bfdb-4db1-b8e0-605b277ad811
iii)
5fe2434f-9e7e-40e8-96e0-c62076980ce6
iv)
564c2f58-160e-4bfc-8c5d-7ea36d33e0ee
v)
8a086170-e71f-4d3c-9bdd-10e2dfdc9fb3
vi)
78888c5a-a824-42eb-96b2-c4f77c89cd8a

@alexcreasy alexcreasy added the priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. label May 22, 2023
@alexcreasy alexcreasy added this to the Explainability Phase 1 milestone May 22, 2023
@github-project-automation github-project-automation bot moved this to Needs prioritization in ODH Dashboard Planning May 22, 2023
@alexcreasy alexcreasy added the feature/model-serving Model Serving Feature label May 22, 2023
@alexcreasy alexcreasy moved this from Needs prioritization to To do in ODH Dashboard Planning May 22, 2023
@alexcreasy
Copy link
Contributor Author

Ticket updated with latest mocks.

@alexcreasy alexcreasy linked a pull request Jun 7, 2023 that will close this issue
6 tasks
@alexcreasy alexcreasy moved this from To do to Done in ODH Dashboard Planning Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/model-serving Model Serving Feature priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants