Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Remove Colour From Card Support Tag #958

Closed
1 task done
andrewballantyne opened this issue Feb 17, 2023 · 0 comments · Fixed by #959
Closed
1 task done

[Bug]: Remove Colour From Card Support Tag #958

andrewballantyne opened this issue Feb 17, 2023 · 0 comments · Fixed by #959
Assignees
@DaoDaoNoCode
Labels
infrastructure Anything non feature/* related that improves general working of the Dashboard kind/bug Something isn't working priority/low An issue with the product that doesn't impact the user much or not at all (ie tech debt) visual changes An issue where the User Interface or Experience changes
Milestone
v2.7.0

Comments

@andrewballantyne
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

In #863 we fixed some of the logic and added tooltips for the support tag. There was some old code in there with colours that had logic flaws so we fixed it along the way.

image

Turns out the change to add colours was an old design, code was unreachable before and should have just been removed. Missed confirming with UX during this effort.

Expected Behavior

Remove the CSS code and the colour references. They should all be default grey labels from PF.

Steps To Reproduce

Install ISVs or duplicate the Jupyter tile and change the support value between one of these three values:

  • 'Red Hat managed'
  • 'Partner managed'
  • 'Self-managed'

All should be grey.

Workaround (if any)

No response

What browsers are you seeing the problem on?

No response

Open Data Hub Version

Dashboard: to be 1.7.0

Anything else

No response
@andrewballantyne andrewballantyne added kind/bug Something isn't working untriaged Indicates the newly create issue has not been triaged yet infrastructure Anything non feature/* related that improves general working of the Dashboard priority/low An issue with the product that doesn't impact the user much or not at all (ie tech debt) and removed untriaged Indicates the newly create issue has not been triaged yet labels Feb 17, 2023
@andrewballantyne andrewballantyne moved this from Backlog to In progress in ODH Dashboard Planning Feb 17, 2023
@andrewballantyne andrewballantyne added this to the Next Release milestone Feb 17, 2023
@andrewballantyne andrewballantyne added the visual changes An issue where the User Interface or Experience changes label Feb 17, 2023
@DaoDaoNoCode DaoDaoNoCode mentioned this issue Feb 17, 2023
Merged
3 tasks
@andrewballantyne andrewballantyne moved this from In progress to In review in ODH Dashboard Planning Feb 17, 2023
@github-project-automation github-project-automation bot moved this from In review to Done in ODH Dashboard Planning Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DaoDaoNoCode DaoDaoNoCode

Labels
infrastructure Anything non feature/* related that improves general working of the Dashboard kind/bug Something isn't working priority/low An issue with the product that doesn't impact the user much or not at all (ie tech debt) visual changes An issue where the User Interface or Experience changes
Projects
No open projects
ODH Dashboard Planning
Archived in project
Milestone
v2.7.0
Development

Successfully merging a pull request may close this issue.

Remove warning status from the app card badge DaoDaoNoCode/odh-dashboard
2 participants
@andrewballantyne @DaoDaoNoCode