Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Enable Storybook Tests on PRs #984

Closed
andrewballantyne opened this issue Mar 1, 2023 · 0 comments · Fixed by #1039
Closed

[Feature Request]: Enable Storybook Tests on PRs #984

andrewballantyne opened this issue Mar 1, 2023 · 0 comments · Fixed by #1039
Assignees
@Gkrumbach07
Labels
infrastructure Anything non feature/* related that improves general working of the Dashboard kind/enhancement New functionality request (existing augments or new additions) priority/normal An issue with the product; fix when possible quality An issue to improve the quality of our code -- e2e or unit test related
Milestone
v2.9.0

Comments

@andrewballantyne
Copy link
Member

andrewballantyne commented Mar 1, 2023 •
edited
Loading

Feature description

Follows up on #962

We have a new test tool of Storybook tests. They make a good isolated test of a component. This will be great for testing functionality and echoing when functionality breaks or when we fail a11y. This was not enabled on the first pass, we only wanted it to be a foundational PR.

  • Enable the tests on all PRs going forward -- a failure in test should stop merging
  • Fix the remaining issues if not already fixed (a11y effort is separate of this work)

Describe alternatives you've considered

No response

Anything else?

Handle documentation request on #962's PR. #974 (comment)
@andrewballantyne andrewballantyne added kind/enhancement New functionality request (existing augments or new additions) untriaged Indicates the newly create issue has not been triaged yet infrastructure Anything non feature/* related that improves general working of the Dashboard quality An issue to improve the quality of our code -- e2e or unit test related priority/normal An issue with the product; fix when possible and removed untriaged Indicates the newly create issue has not been triaged yet labels Mar 1, 2023
@andrewballantyne andrewballantyne moved this from Backlog to To do in ODH Dashboard Planning Mar 1, 2023
@andrewballantyne andrewballantyne added this to the Next Release milestone Mar 13, 2023
@Gkrumbach07 Gkrumbach07 mentioned this issue Mar 22, 2023
Merged
6 tasks
@Gkrumbach07 Gkrumbach07 moved this from To do to In review in ODH Dashboard Planning Mar 24, 2023
@github-project-automation github-project-automation bot moved this from In review to Done in ODH Dashboard Planning Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gkrumbach07 Gkrumbach07

Labels
infrastructure Anything non feature/* related that improves general working of the Dashboard kind/enhancement New functionality request (existing augments or new additions) priority/normal An issue with the product; fix when possible quality An issue to improve the quality of our code -- e2e or unit test related
Projects
No open projects
ODH Dashboard Planning
Archived in project
Milestone
v2.9.0
Development

Successfully merging a pull request may close this issue.

Add storybook test github action Gkrumbach07/odh-dashboard
2 participants
@andrewballantyne @Gkrumbach07