Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: tokenization in Tokenize and Generate does not match if ADD_SPECIAL_TOKENS=False #141

Closed
tjohnson31415 opened this issue Sep 25, 2024 · 0 comments · Fixed by #144
Closed

bug: tokenization in Tokenize and Generate does not match if ADD_SPECIAL_TOKENS=False #141

tjohnson31415 opened this issue Sep 25, 2024 · 0 comments · Fixed by #144

Comments

@tjohnson31415
Copy link
Contributor

tjohnson31415 commented Sep 25, 2024 •
edited by prashantgupta24
Loading

The usage of add_special_tokens in Generate is not replicated in Tokenize. This means that the tokenization result/count will be different if ADD_SPECIAL_TOKENS=False.

Let's make sure to add a unit test and integration test for it if applicable!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add_special_tokens in tokenize rafvasq/vllm-tgis-adapter
1 participant
@tjohnson31415