-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we move deps into dev deps? #7
Comments
So the problem is not that simple. We should provide 2 ways to use the plugin (and all other plugins too) :
This means that we may change the |
Exactly. According to the Browserify docs, the main field should point to the uncompiled JavaScript at As it stands now, the dependencies are redundant since the main field points to the compiled (bundled) JavaScript.
I was recently alerted to https://npmcdn.com. It encourages you not to put the dist folder in the git repository. Instead, you package it inside the npm module and publish it along with the package. npmcdn then allows you to reference that file through its proxy. I find it incredibly annoying to have to check in the dist file for every change to the module, so I think we should stop doing that. The compiled JavaScript file is a build artifact and build artifacts don't belong in the git repository. |
The package published on NPM already contains the dependencies like
prism
orinsert-css
bundled in the minified. Maybe we should move all the deps into devDeps?@mojavelinux WDYT?
The text was updated successfully, but these errors were encountered: