Skip to content
This repository has been archived by the owner on Mar 31, 2021. It is now read-only.

Fix: column name in result table shows alias if alias exists #75

Merged
merged 2 commits into from
Jun 9, 2020
Merged

Fix: column name in result table shows alias if alias exists #75

merged 2 commits into from
Jun 9, 2020

Conversation

chloe-zh
Copy link
Contributor

@chloe-zh chloe-zh commented Jun 9, 2020

Issue #, if available:

Description of changes:

  • Fixed the fix column not showing field alias

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chloe-zh chloe-zh linked an issue Jun 9, 2020 that may be closed by this pull request
Column name in table header doesn't use field alias #45
Closed
zhongnansu
zhongnansu approved these changes Jun 9, 2020
View reviewed changes
public/components/Main/main.tsx Outdated
try {
alias = _.get(field, 'alias');
} catch (e) {
console.log("No alias for field " + field);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Np. I suggest using either single quote or double quote for js, not both. One reason I am more for single quote is

A single quoted string can have double quotes within it without having to escape them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks for raising it!

@chloe-zh chloe-zh merged commit 724cccd into amazon-archives:master Jun 9, 2020
@chloe-zh chloe-zh mentioned this pull request Aug 5, 2020
Merged
chloe-zh added a commit that referenced this pull request Aug 5, 2020
@chloe-zh
Merged #84 and #75 to ODFE1.8 (#87)
72211d0 
* Fix: column name in result table shows alias if alias exists (#75)

* fix issue of column name not showing alias

* update

* (#84) Fix: use column name if alias is an empty string
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zhongnansu zhongnansu zhongnansu approved these changes

@joshuali925 joshuali925 Awaiting requested review from joshuali925

@dai-chen dai-chen Awaiting requested review from dai-chen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Column name in table header doesn't use field alias
2 participants
@chloe-zh @zhongnansu