Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PV/Dataset metrics #272

Open
tahajahangir opened this issue Jan 7, 2021 · 5 comments
Open

PV/Dataset metrics #272

tahajahangir opened this issue Jan 7, 2021 · 5 comments
Labels
enhancement Add new functionality to existing feature good first issue Good for newcomers help wanted Need help from community contributors. Metrics and Alerting metric and alert reporting related changes.

Comments

@tahajahangir
Copy link

ZFS exposes several dataset metrics:

$ cat /proc/spl/kstat/zfs/ZPOOL NAME/objset-0x4c3
49 1 0x01 7 1904 882869614188 7661358045725488
name                            type data
dataset_name                    7    zfspv-pool/pvc-d1af69c6-b004-4df5-aa57-5e027884af59
writes                          4    162659962
nwritten                        4    169357302418427
reads                           4    19860562
nread                           4    20787773826774
nunlinks                        4    5326
nunlinked                       4    5326

Can we have this metrics per PV?

The related issue in prometheus/node_exporter for scraping these metrics:
prometheus/node_exporter#1602

@kmova kmova added the Need community involvement Needs community involvement on some action item. label Jan 9, 2021
@pawanpraka1
Copy link
Contributor

@tahajahangir, if promethes's node exporter exposes it, then it should be available for ZFS-LocalPV also. Could you try the latest node exporter?

@tahajahangir
Copy link
Author

I didn't understand the phrase " it should be available for ZFS-LocalPV".
The node exporter metrics are scraped and available (like node_zfs_zpool_dataset_nread), but they contain only dataset-name (not namespace/pvc-name). We created a dashboard with expressions like this to join this data with pvc-name:

label_replace((rate(node_zfs_zpool_dataset_nread[1m])),"volumename", "$1", "dataset", ".*/(.*)" )
* on(volumename) group_left(persistentvolumeclaim, namespace)
kube_persistentvolumeclaim_info{cluster=~"$cluster", namespace=~"$namespace", persistentvolumeclaim=~"$volume"}

@pawanpraka1

@pawanpraka1
Copy link
Contributor

This is great @tahajahangir. Adding this to our roadmap. Thanks.

@giridharshankar013 giridharshankar013 added the backlog Will be picked up as a roadmap item. label Apr 20, 2022
@sinhaashish
Copy link
Member

@tahajahangir are you still interested in contributing this to community?

@Abhinandan-Purkait Abhinandan-Purkait added help wanted Need help from community contributors. Metrics and Alerting metric and alert reporting related changes. enhancement Add new functionality to existing feature and removed Need community involvement Needs community involvement on some action item. backlog Will be picked up as a roadmap item. labels Jun 6, 2024
@avishnu avishnu added the good first issue Good for newcomers label Sep 24, 2024
@avishnu avishnu added this to the v4.3 milestone Sep 24, 2024
@avishnu
Copy link
Member

avishnu commented Sep 24, 2024

This seems a useful functionality to have, as it is about visualizing the metrics. Scoping this for v4.3

@avishnu avishnu removed this from the v4.3 milestone Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Add new functionality to existing feature good first issue Good for newcomers help wanted Need help from community contributors. Metrics and Alerting metric and alert reporting related changes.
Projects
Status: No status
Development

No branches or pull requests

7 participants