-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop usage of auto generated EduSharing client code #51
Comments
After some discussion with @torsten-simon and @Criamos we came up with the preferred idea of moving the autgenerated code to a dedicated python package which gets published at pypi. Then we can remove the autogenerated code from here. Also the current occurrences where we use Plan would be to use https://openapi-generator.tech/docs/generators/python (as before). |
I played around a little with the openapi-tools generator:
The current state of what I got so far is available in https://github.com/MRuecklCC/edu-sharing-client-python As a next step, I would try to report/fix the issue of the |
After looking at the source code of both https://github.com/openapi-generators/openapi-python-client and https://github.com/OpenAPITools/openapi-generator I decided that I like the first one a lot more... For reference I also created the following issue: OpenAPITools/openapi-generator#12986 |
in the future, if you want to reconsider using the python-experimental generator. I fixed you filed issue in this PR. So your spec now works with our generator. |
Currently, the
es_connector.py
file makes use of both:requests
package to issue requests e.g. to update thumbnail or fulltext (e.g. here)edu_sharing_client
directory which was once autogenerated in 674bb93 (not modified since then and likely partially outdated).I propose to:
edu_sharing_client
directoryrequests
library.EduSharing.iamApi.create_group
EduSharing.iamApi.search_groups
EduSharing.iamApi.get_group
EduSharing.bulkApi.find
EduSharing.bulkApi.sync
EduSharing.nodeApi.set_permission
Alternatively, we can implement a extremly simplified version of the EduSharing client code that provides only the hand full of methods needed and separates the authentication/authorisation/validation out of the
EduSharing
class.The text was updated successfully, but these errors were encountered: