Skip to content
This repository has been archived by the owner on Jul 18, 2024. It is now read-only.

Remove disallowed generic PropTypes workarounds #81

Closed
Tracked by #71
arbrandes opened this issue Oct 21, 2022 · 4 comments
Closed
Tracked by #71

Remove disallowed generic PropTypes workarounds #81

arbrandes opened this issue Oct 21, 2022 · 4 comments
Labels
bug Report of or fix for something that isn't working as intended

Comments

@arbrandes
Copy link
Contributor

arbrandes commented Oct 21, 2022

On the Course Import page we're forcing the use of generic object PropType via an ugly PropTypes.objectOf(PropTypes.object). See here:

https://github.com/openedx/frontend-app-library-authoring/blob/f62d0aa/src/library-authoring/course-import/CourseImportPage.jsx#L151

Remove that and alter the ongoingImport data structure accordingly so we can use a definite PropType.

@arbrandes arbrandes added the bug Report of or fix for something that isn't working as intended label Dec 9, 2022
@jristau1984
Copy link
Contributor

This has been brought into the 2U Library Authoring epic with this internal ticket: https://2u-internal.atlassian.net/browse/TNL-10592

@navinkarkera
Copy link
Contributor

@jristau1984 @arbrandes Is this issue still relevant?

@arbrandes
Copy link
Contributor Author

Yes, the hack is still there:

https://github.com/openedx/frontend-app-library-authoring/blob/f62d0aa/src/library-authoring/course-import/CourseImportPage.jsx#L151

@kdmccormick
Copy link
Contributor

Closing per #439

@kdmccormick kdmccormick closed this as not planned Won't fix, can't repro, duplicate, stale Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Report of or fix for something that isn't working as intended
Projects
None yet
Development

No branches or pull requests

4 participants