Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

As a developer I want better theming support in Tutor #11

Closed
kdmccormick opened this issue Jan 27, 2022 · 4 comments
Closed

As a developer I want better theming support in Tutor #11

kdmccormick opened this issue Jan 27, 2022 · 4 comments
Labels
wontfix This will not be worked on

Comments

@kdmccormick
Copy link
Collaborator

kdmccormick commented Jan 27, 2022

Copied in from the existing backlog. Needs grooming.


From the Tutor OEP:

There should be a way to reuse the same base LMS image with different themes without having to bake them into the image

Note: there are different ways to address this. I suspect that there will be different solutions for the docker-compose and the Kubernetes deployments.

@kdmccormick kdmccormick changed the title . As a developer I want better theming support in Tutor Jan 27, 2022
@regisb
Copy link

regisb commented Feb 4, 2022

There should be a way to reuse the same base LMS image with different themes without having to bake them into the image

I'm not so sure about that one. The whole idea of Docker is that everything should ship as a single image. The only way I see this could work were if we stored static assets in object storage, such as S3/MinIO. With this approach, we could re-generate static assets from a different host, and changes would be visible live in production. But we would not be able to publish changes made to html files, and I suspect this would be a major issue for most people.

This is typically the type of issue that other contributors should work on, because I have no idea what is the actual problem that we need to solve.

@kdmccormick
Copy link
Collaborator Author

Yeah, I'm not familiar with the problem either. I copied it from the google sheet, which I think drew it from the wishlist in the Tutor OEP ADR. There's some discussion on the ADR's PR as well.

@e0d or @arbrandes - Do you know what problem is being identified here and whether it's something we should have in our backlog for Tutor?

@arbrandes
Copy link

@kdmccormick, this is an idea I captured while thinking up ways to reduce the necessity of rebuilding Tutor images. And as @regisb points out, yes, I was thinking in terms of using object storage to retrieve assets/artifacts at runtime.

But I clearly did not think it through, as indeed HTML would be an intractable problem for anything rendered Django-side. So if this is the primary purpose of this ticket, then we can drop it. (The idea might still be valid for SPAs like our MFEs, but there are probably better places to track this than here.)

@kdmccormick
Copy link
Collaborator Author

Thanks for the details @arbrandes .

HTML would be an intractable problem for anything rendered Django-side. So if this is the primary purpose of this ticket, then we can drop it. (The idea might still be valid for SPAs like our MFEs, but there are probably better places to track this than here.)

Agreed 👍🏻

Repository owner moved this from Ungroomed (Kyle) to Closed in Tutor DevEnv Adoption (OLD BOARD) Feb 17, 2022
@kdmccormick kdmccormick added the wontfix This will not be worked on label Feb 17, 2022
@kdmccormick kdmccormick closed this as not planned Won't fix, can't repro, duplicate, stale Feb 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants