Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please create codecov keys for edx-submissions repository #1125

Closed
pomegranited opened this issue May 1, 2024 · 8 comments
Closed

Please create codecov keys for edx-submissions repository #1125

pomegranited opened this issue May 1, 2024 · 8 comments
Assignees
Labels
github-request Request for change to access level or settings in the openedx GitHub organization.

Comments

@pomegranited
Copy link

Firm Name

OpenCraft

Urgency

Medium (< 2 weeks)

Requested Change

Please create codecov tokens for https://github.com/openedx/edx-submissions and add the value to the secrets so that CI will pass, cf openedx/edx-submissions#241

Reasoning

  • We need code coverage reports to ensure code quality on this repository.
@kdmccormick
Copy link
Member

Hi @pomegranited , can do.

By the way, I think you may have picked "Axim Engineering Task" from the request board? We don't actually get notified when someone creates an issue that way. Choose any of the "Request" options next time, and it'll show up on our on-call board right away 🙂

@kdmccormick
Copy link
Member

Ah, I think what happened is that you removed [GH Request] from the title. Regardless, this is on our board now, sorry for the delay.

@kdmccormick kdmccormick added the github-request Request for change to access level or settings in the openedx GitHub organization. label May 13, 2024
@kdmccormick kdmccormick self-assigned this May 13, 2024
@pomegranited
Copy link
Author

Oh thanks @kdmccormick ! I can't remember exactly what options I saw when I created this ticket, but now I can see I should have chosen "GitHub Request - Repository Settings". Thanks for moving this into the queue :)

@kdmccormick
Copy link
Member

@pomegranited No problem! I added the CODECOV_TOKEN as specified in https://openedx.atlassian.net/wiki/spaces/COMM/pages/3438280709/Adding+Codecov. Hopefully codecov will work on that PR now?

@kdmccormick
Copy link
Member

On second thought, I might be confused about how codecov is supposed to be configured. I'll come back to this tomorrow.

@pomegranited
Copy link
Author

Thanks @kdmccormick :) I don't know if it helps, but https://github.com/openedx/completion has the CODECOV_TOKEN set up already.

@kdmccormick
Copy link
Member

@pomegranited I had the secret wrong the first time. Should be all set now, try pushing to your PR :) If that doesn't work, feel free to reopen this.

@pomegranited
Copy link
Author

Thank you for your help @kdmccormick ! It's all working now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-request Request for change to access level or settings in the openedx GitHub organization.
Projects
Archived in project
Development

No branches or pull requests

2 participants