Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH Request] CLA list verification for whuang1202 bilaltahir21 TheEarlyNerd #390

Closed
jsoto2u opened this issue Jul 21, 2022 · 4 comments
Closed
Assignees
Labels
github-request Request for change to access level or settings in the openedx GitHub organization.

Comments

@jsoto2u
Copy link

jsoto2u commented Jul 21, 2022

Firm Name

2U

Urgency

High Urgency

Requested Change

These 3 users are in the org but from the Help Desk ticket received at 2U are still having issues being marked as external contributors. Speaking with Natalia Berdnikov who submitted the ticket to us for example, Kaleb Davenport (TheEarlyNerd) apparently shows up as theearlynerd in the CLA list.

I don't know if this was addressed for any of these users before getting to me at Help Desk so if they have just let me know and I can relay that on our end

Reasoning

So these members PR don't get flagged as External Contributors and have the openedx-webhook inform them their PR won't get reviewed.

@jsoto2u jsoto2u added the github-request Request for change to access level or settings in the openedx GitHub organization. label Jul 21, 2022
@openedx-workflow-automation
Copy link

Thank you for your report! @openedx/tcril-oncall will take a look as soon as they can.

@e0d
Copy link

e0d commented Aug 8, 2022

Kaleb has two records, one with an individual CLA, one with the 2U CLA. The individual CLA record had the wrong casing, I've disabled that temporarily. This will be fixed in the next feed later today.

@Carlos-Muniz do you know whether having two entries with different cases would cause the CLA check to behave improperly?

@e0d e0d moved this from To Do - Backlog to In Progress in Axim Engineering Tasks Aug 8, 2022
@feanil
Copy link
Contributor

feanil commented Aug 8, 2022

I looked at this with @Carlos-Muniz and having two entries should not cause any improper behavior. The bot will pick up the version that matches the casing the username has on github so the other entry will be ignored. It looks like everything is working as expected on our side, the PR from before the proper casing entry was added failed the CLA but the one after the correct entry was added, passed.

@feanil
Copy link
Contributor

feanil commented Aug 10, 2022

@jsoto2u looks like all the people are in the list correctly now so it may just be a timing issue. The CLA list is updated only once every 24hrs so it may just not have been filed on the 2U side early enough to be ready to go by the time the user is ready to submit contributions.

@feanil feanil closed this as completed Aug 10, 2022
Repository owner moved this from In Progress to Done in Axim Engineering Tasks Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-request Request for change to access level or settings in the openedx GitHub organization.
Projects
Archived in project
Development

No branches or pull requests

3 participants