Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review the sphinx-book-theme for a11y issues that are too large to deal with #230

Closed
Tracked by #200
feanil opened this issue Dec 20, 2022 · 3 comments
Closed
Tracked by #200
Assignees

Comments

@feanil
Copy link
Contributor

feanil commented Dec 20, 2022

If we find major issues, we should work to fix them upstream or consider moving to a more accessible theme with a strong preference for fixing up-stream over maintaining our own theme.

@feanil feanil changed the title We'll review the new theme for a11y issues that are too large to deal with. Review the sphinx-book-theme for a11y issues that are too large to deal with Dec 20, 2022
@feanil feanil transferred this issue from openedx-unsupported/edx-sphinx-theme Dec 20, 2022
@feanil feanil moved this to Backlog - Other in docs.openedx.org Feb 9, 2023
@feanil feanil moved this from Backlog - Other to Backlog - To Write in docs.openedx.org Feb 9, 2023
@feanil feanil moved this from Backlog - To Write to Backlog - Other in docs.openedx.org Feb 9, 2023
@feanil
Copy link
Contributor Author

feanil commented Mar 1, 2023

There weren't too many issues but one that was on the main page was a contrast issue with the "Home" buttons.

I tried to override the primary color for the design theme to deal with this but there seems to be a bug where our custom.css file loads earlier than the design-style.css file that the extension provides.

I made executablebooks/sphinx-design#124 upstream to just fix the upstream theme and I'm gonna spend a little bit more time to see if I can figure out why the CSS is loading in the wrong order.

@feanil
Copy link
Contributor Author

feanil commented Mar 1, 2023

#265 is a work-around for now until we can land the upstream PR and re-visit this.

After this PR lands, I think we can call this done for now.

@feanil feanil self-assigned this Mar 1, 2023
@feanil feanil moved this from Backlog - Other to In Progress - tCRIL in docs.openedx.org Mar 1, 2023
@feanil
Copy link
Contributor Author

feanil commented Mar 2, 2023

PR has landed, so this should be all set.

@feanil feanil closed this as completed Mar 2, 2023
@github-project-automation github-project-automation bot moved this from In Progress - tCRIL to Done in docs.openedx.org Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant