-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: standardize make extract_translations #1751
feat: standardize make extract_translations #1751
Conversation
Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Hi @iloveagent57 , I'm starting a PR for FC-0012 Project. Can you please explain why there are two translation directories? one for consent and integrate apps, and another for enterprise app. Shouldn't we combine them all in a single translation directory? |
63c37c8
to
41a31a5
Compare
@shadinaif sorry for the delay in responding, I'll try to find someone with historical context on this. I don't personally know the answer. |
@saleem-latif had some context here that he shared with me:
|
@shadinaif ping, reply above ^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testing my new permissions, not a real review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testing my new permissions, not a real review
Thank you @iloveagent57 ! |
Hi @shadinaif and @OmarIthawi - just checking to see if this PR can be closed? |
dfd34e8
to
c88d9d0
Compare
Thank you for the follow-up @mphilbrick211 , I'm testing it now to convert it into (Ready for review) |
@shadinaif @iloveagent57 looks like tests need to be re-enabled. |
c88d9d0
to
bf4a807
Compare
This PR needs openedx/edx-enterprise#1751 before it's merged. Refs: FC-0012 OEP-58
This PR needs openedx/edx-enterprise#1751 before it's merged. Refs: FC-0012 OEP-58
This PR needs openedx/edx-enterprise#1751 before it's merged. Refs: FC-0012 OEP-58
This PR needs openedx/edx-enterprise#1751 before it's merged. Refs: FC-0012 OEP-58
This PR needs openedx/edx-enterprise#1751 before it's merged. Refs: FC-0012 OEP-58
@iloveagent57 would you mind enabling tests one more time? It should be ready to merge. |
Refs: FC-0012 OEP-58
bf4a807
to
8309937
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thank you!
@iloveagent57 I'd like to merge this. You are listed as "please inform" on the spreadsheet. If there's any reason I should hold off please let me know, otherwise I'll plan on merging this tomorrow morning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested it locally and it looks good to me. Thanks @shadinaif!
@shadinaif 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This PR needs openedx/edx-enterprise#1751 before it's merged. Refs: FC-0012 OEP-58
feat: standardize make extract_translations
This PR prepares the repository to comply with openedx-translations by doing the following:
conf/locale
and converttranslations
into a symbolic link toconf/locale
. The reason behind that is to comply with openedx-translations mechanism that requires translation files to be inconf/locale
directory. This fix will avoid the need to modifyfind
commands heremake extract_translations
to build a file nameddjango.po
instead oftext.po
. And create a symbolic link fromtext.po
todjango.po
. This is because openedx-translations requiresdjango.po
as the name of the file. And it must be a valid file (not a link) because it usesgit add
hereReferences
This pull request is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.
Check the links above for full information about the overall project.
Internalization is being rearchitected in Open edX Python, XBlock, Micro-frontend, and other projects. There are a number of immediately visible changes:
.json
,.po
or.mo
files will be committed into the repos.make extract_translations
in all repositoriesBreaking Changes
One of the primary goals of the project is to avoid breaking changes. If you noticed any suspicious code, please raise your concern. But before that, please know the strategy we're following to avoid breaking changes
For XBlocks:
conf/locale
. Therefore, we are creating a link fromconf/locale
totranslations
so Atlas can find the path without disrupting the current way of having translations locally within the XBlocks