feat: standardize make extract_translations

[shadinaif]

feat: standardize make extract_translations

This PR prepares the repository to comply with openedx-translations by doing the following:

• Move all local translations to conf/locale and convert translations into a symbolic link to conf/locale. The reason behind that is to comply with openedx-translations mechanism that requires translation files to be in conf/locale directory. This fix will avoid the need to modify find commands here
• Add the translation command make extract_translations to build a file named django.po instead of text.po. And create a symbolic link from text.po to django.po. This is because openedx-translations requires django.po as the name of the file. And it must be a valid file (not a link) because it uses git add here

• Tested on devstack palm to ensure that everything renders fine
• Tested on devstack palm to ensure that local translation still works

References

This pull request is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.

Check the links above for full information about the overall project.

Internalization is being rearchitected in Open edX Python, XBlock, Micro-frontend, and other projects. There are a number of immediately visible changes:

• Remove source and language translations from the repositories, hence no .json, .po or .mo files will be committed into the repos.
• Add standardized make extract_translations in all repositories
• Push user-facing messages strings into openedx/openedx-translations.
• Integrate root repositories with openedx/openedx-atlas to pull translations on build/deploy time

Breaking Changes

One of the primary goals of the project is to avoid breaking changes. If you noticed any suspicious code, please raise your concern. But before that, please know the strategy we're following to avoid breaking changes

For XBlocks:

• The standard translation path must be conf/locale. Therefore, we are creating a link from conf/locale to translations so Atlas can find the path without disrupting the current way of having translations locally within the XBlocks
• openedx-translations will have a related PR that adds the XBlock to the pipeline. This will not affect the current way of managing/updating translations
• At the end of the project, a clear change log will be added and all translations will be handled by Atlas. Thus, the local translation will be removed from the repo within the version bump
• A notification for the community will be published to ensure that everyone knows why translations directories are removed from all repos

[openedx-webhooks]

Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[shadinaif]

Hi @iloveagent57 , I'm starting a PR for FC-0012 Project. Can you please explain why there are two translation directories? one for consent and integrate apps, and another for enterprise app. Shouldn't we combine them all in a single translation directory?

cc: @OmarIthawi, @brian-smith-tcril

[iloveagent57]

@shadinaif sorry for the delay in responding, I'll try to find someone with historical context on this. I don't personally know the answer.

[iloveagent57]

@saleem-latif had some context here that he shared with me:
PR: #1037

I think the directory conf/locale was created alongside the edx-enterprise app. Initially, it only had markings for strings in the en directory, no translations were added. With ENT-3529 we wanted to add translations for Spanish (specifically for data sharing page. More information in the comments of ENT-3529 on this.)
The reason I added a new directory at this point is because Django provided following 3 ways to enable translations

1. The directories listed in LOCALE_PATHS have the highest precedence, with the ones appearing first having higher precedence than the ones appearing later.
2. Then, it looks for and uses if it exists a locale directory in each of the installed apps listed in INSTALLED_APPS. The ones appearing first have higher precedence than the ones appearing later.
3. Finally, the Django-provided base translation in django/conf/locale is used as a fallback.
   ref: https://docs.djangoproject.com/en/4.2/topics/i18n/translation/#how-django-discovers-translations

For external Django apps like edx-enterprise , IMO the best approach is to use 2nd approach, which led to the creation of locale directory.
I should have remove conf/locale directory at this point, but I do not remember if I forgot to do so or if there was some other reason. I think we can remove this directory now if removing it does not cause any issues.

[iloveagent57]

@shadinaif ping, reply above ^

[OmarIthawi]

testing my new permissions, not a real review

[OmarIthawi]

testing my new permissions, not a real review

[shadinaif]

Thank you @iloveagent57 !

[mphilbrick211]

Hi @shadinaif and @OmarIthawi - just checking to see if this PR can be closed?

[shadinaif]

Thank you for the follow-up @mphilbrick211 , I'm testing it now to convert it into (Ready for review)

[mphilbrick211]

@shadinaif @iloveagent57 looks like tests need to be re-enabled.

[OmarIthawi]

@iloveagent57 would you mind enabling tests one more time? It should be ready to merge.

[brian-smith-tcril]

This looks great! Thank you!

[brian-smith-tcril]

@iloveagent57 I'd like to merge this. You are listed as "please inform" on the spreadsheet. If there's any reason I should hold off please let me know, otherwise I'll plan on merging this tomorrow morning.

[OmarIthawi]

I've tested it locally and it looks good to me. Thanks @shadinaif!

[openedx-webhooks]

@shadinaif 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.