Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added channel_name for api call logs records #2023

Merged
merged 8 commits into from
Feb 20, 2024
Merged

Added channel_name for api call logs records #2023

merged 8 commits into from
Feb 20, 2024

Conversation

MueezKhan246
Copy link
Contributor

Description:
Added channel_name for making it easier to delete api call logs records.

JIRA:
https://2u-internal.atlassian.net/jira/software/c/projects/ENT/issues/ENT-8020

justEhmadSaeed
justEhmadSaeed approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@justEhmadSaeed justEhmadSaeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

sameenfatima78
sameenfatima78 reviewed Feb 19, 2024
View reviewed changes
Copy link
Member

@sameenfatima78 sameenfatima78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we shouldn't hardcode the name. try using constants instead

@MueezKhan246
Copy link
Contributor Author

we shouldn't hardcode the name. try using constants instead
@Sameen i was searching if the names were defined in a dicts or enums but could not find it.
just replaced it with self.enterprise_configuration.channel_code() shared by @hamzawaleed01.

@MueezKhan246 MueezKhan246 merged commit 844d9a6 into master Feb 20, 2024
9 checks passed
@MueezKhan246 MueezKhan246 deleted the MueezKhan/Add-Channel-Name-To-API-Call-Logs-ENT-8020 branch February 20, 2024 10:02
sameenfatima78
sameenfatima78 reviewed Feb 20, 2024
View reviewed changes
Copy link
Member

@sameenfatima78 sameenfatima78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks all good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sameenfatima78 sameenfatima78 sameenfatima78 left review comments

@justEhmadSaeed justEhmadSaeed justEhmadSaeed approved these changes

@hamzawaleed01 hamzawaleed01 hamzawaleed01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MueezKhan246 @justEhmadSaeed @sameenfatima78 @hamzawaleed01