-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pending enterprise customer admin user view set permission update #2122
Pending enterprise customer admin user view set permission update #2122
Conversation
…Khan/Pending-EnterpriseCustomer-AdminUser-ViewSet-Permission-Update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MueezKhan246 I know it's indirectly being checked in other tests but still can we add one more test that checks if user is part of provisioning group? just to make sure that valid exception is being raised.
…Khan/Pending-EnterpriseCustomer-AdminUser-ViewSet-Permission-Update
@hamzawaleed01 i have updated |
…Khan/Pending-EnterpriseCustomer-AdminUser-ViewSet-Permission-Update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we tested this API via browser?
@@ -17,6 +17,10 @@ Unreleased | |||
---------- | |||
* nothing unreleased | |||
|
|||
[4.19.8] | |||
-------- | |||
* chore: updated permission class ``IsInProvisioningAdminGroup`` for ``PendingEnterpriseCustomerAdminUser`` viewpoint and handled exceptions in serializer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't a chore commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sameenfatima78 feedback was to avoid using feat
for this.
@sameenfatima78 in swagger? |
Description:
Added IsInProvisioningAdminGroup permission class and updated exception handling in serializer.
JIRA:
https://2u-internal.atlassian.net/jira/software/c/projects/ENT/issues/ENT-8995