Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pending enterprise customer admin user view set permission update #2122

Merged
merged 12 commits into from
Jun 5, 2024
Merged

Pending enterprise customer admin user view set permission update #2122

merged 12 commits into from
Jun 5, 2024

Conversation

MueezKhan246
Copy link
Contributor

Description:
Added IsInProvisioningAdminGroup permission class and updated exception handling in serializer.

JIRA:
https://2u-internal.atlassian.net/jira/software/c/projects/ENT/issues/ENT-8995

hamzawaleed01
hamzawaleed01 approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@hamzawaleed01 hamzawaleed01 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MueezKhan246 I know it's indirectly being checked in other tests but still can we add one more test that checks if user is part of provisioning group? just to make sure that valid exception is being raised.

zamanafzal
zamanafzal reviewed Jun 4, 2024
View reviewed changes
CHANGELOG.rst Outdated Show resolved Hide resolved
@MueezKhan246
Copy link
Contributor Author

@MueezKhan246 I know it's indirectly being checked in other tests but still can we add one more test that checks if user is part of provisioning group? just to make sure that valid exception is being raised.

@hamzawaleed01 i have updated test_post_pending_enterprise_customer_unauthorized_user for this, kindly check.

@MueezKhan246 MueezKhan246 merged commit 14b0cde into master Jun 5, 2024
13 checks passed
@MueezKhan246 MueezKhan246 deleted the MueezKhan/Pending-EnterpriseCustomer-AdminUser-ViewSet-Permission-Update branch June 5, 2024 08:34
@MueezKhan246 MueezKhan246 mentioned this pull request Jun 5, 2024
Merged
sameenfatima78
sameenfatima78 reviewed Jun 5, 2024
View reviewed changes
Copy link
Member

@sameenfatima78 sameenfatima78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we tested this API via browser?

CHANGELOG.rst
@@ -17,6 +17,10 @@ Unreleased
----------
* nothing unreleased

[4.19.8]
--------
* chore: updated permission class ``IsInProvisioningAdminGroup`` for ``PendingEnterpriseCustomerAdminUser`` viewpoint and handled exceptions in serializer.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't a chore commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sameenfatima78 feedback was to avoid using feat for this.

@MueezKhan246
Copy link
Contributor Author

Have we tested this API via browser?

@sameenfatima78 in swagger?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sameenfatima78 sameenfatima78 sameenfatima78 left review comments

@zamanafzal zamanafzal zamanafzal approved these changes

@hamzawaleed01 hamzawaleed01 hamzawaleed01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MueezKhan246 @zamanafzal @sameenfatima78 @hamzawaleed01