Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: pii check stage actually checks PII instead of not at all #2191

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

pwnage101
Copy link
Contributor

No description provided.

Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with 2 minor nits about the PII docstring annotations. Will this need a version bump and CHANGELOG entry?

integrated_channels/blackboard/models.py Outdated Show resolved Hide resolved
integrated_channels/canvas/models.py Outdated Show resolved Hide resolved
@pwnage101 pwnage101 force-pushed the pwnage101/fix-pii-check branch 3 times, most recently from c415f31 to 523363b Compare August 8, 2024 16:46
@pwnage101
Copy link
Contributor Author

Docs test is failing because the RST in a file that I did not edit is invalid:

- **Sync catalog/customer data with enterprise-catalog**

Not fixing in this PR.

@pwnage101 pwnage101 merged commit 27f4a64 into master Aug 8, 2024
8 of 9 checks passed
@pwnage101 pwnage101 deleted the pwnage101/fix-pii-check branch August 8, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants