Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pylint_django plugin #21

Open
clintonb opened this issue Nov 25, 2015 · 3 comments
Open

Remove pylint_django plugin #21

clintonb opened this issue Nov 25, 2015 · 3 comments

Comments

@clintonb
Copy link
Contributor

The pylint_django plugin is required (https://github.com/edx/edx-lint/blob/96f4c58137f73bd4798400c4107dbf1a422dc34f/edx_lint/files/pylintrc#L22), but is not included as a dependency of this package. Unless this is intended only for Django projects, pylint_django should not be a default plugin.
@nedbat
Copy link
Contributor

nedbat commented Nov 25, 2015

pylint_django is listed in setup.py as a dependency.

I can see why we shouldn't include this plugin in all repos, but I'd like to find a way to uniformly apply it to our Django projects.

@clintonb
Copy link
Contributor Author

clintonb commented Dec 2, 2015

It seems I misread setup.py. Closing as there is no immediate need to remove pylint_django.

@clintonb clintonb closed this as completed Dec 2, 2015
@nedbat
Copy link
Contributor

nedbat commented Jan 5, 2016

No need to remove the plugin, but we should disable the message it prints if there's no Django installed:
disable=django-not-available

@nedbat nedbat reopened this Jan 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nedbat @clintonb