-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: v6.7.0 version bump #2208
Conversation
Thanks for the pull request, @pomegranited! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2208 +/- ##
=======================================
Coverage 95.05% 95.05%
=======================================
Files 191 191
Lines 21098 21098
Branches 1904 1904
=======================================
Hits 20055 20055
Misses 779 779
Partials 264 264
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @mphilbrick211 @openedx/content-aurora Could somebody help me out with this version bump by approving here and creating a new release? Sorry to ask, but I'm going on leave tomorrow, and we're trying to get these updates into Redwood, which is cutting soon. Thanks! |
Hi @pomegranited! I don't think Aurora is reviewing pull requests, but let me look into this. |
@pomegranited Do you think this pr is still needed? |
Per https://github.com/openedx/edx-ora2/blob/master/catalog-info.yaml#L16, Aurora maintains this repo. The file was created last month (by @jristau1984), so the info that it contains is probably up-to-date? The main thing that's changed for this repo, I think, is that we should be pinging the Aurora team via @openedx/2u-aurora, and stop using the legacy @openedx/content-aurora handle. Also, it's possible that the settings for this repo need some additional updates -- I tried requesting a review from |
Pull request was closed
@pomegranited Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Oh good, yep, that's all I needed. Thank you!
Noted, thank you :)
I'm able to use the 2u handle ok? Not sure why it doesn't work for you. |
@pomegranited It works for me when I try to use it in a comment, but not in the context of the reviewers field: (The screenshot doesn't show it but I also tried Is it working everywhere for you? |
@itsjeyd Ah.. no, I can't request a review from 2u-aurora either. From github's docs:
Maybe 2u-aurora doesn't have read access to this repo? I'm unable to see the repo settings, so can't find out for myself. @mphilbrick211 can you help? |
@pomegranited @itsjeyd I'm going to check on this, as I'm not sure Aurora is still reviewing. If they are, I'll confirm if they need access. |
@mphilbrick211 yes, 2u-aurora needs to be added to this repo. |
TL;DR - Prepare release version
What changed?
Developer Checklist
Translations and JS/SASS compiledReviewer Checklist
Collectively, these should be completed by reviewers of this PR:
FYI: @openedx/content-aurora