Conversation
mzulqarnain1
force-pushed
the
bom-2245-attempt-2
branch
2 times, most recently
from
00733a8 to
9e7a5be
Compare
mzulqarnain1
force-pushed
the
bom-2245-attempt-2
branch
from
1a14937 to
76f51a4
Compare
|
Your PR has finished running tests. There were no failures. |
jmbowman
left a comment
jmbowman
left a comment
There was a problem hiding this comment.
Looks good as long as the new test successfully reproduced the problem we hit in prod. Please coordinate the deployment with SRE, since there will be some unusual steps with this one. And capture the steps needed in the draft Lilac release notes.
| """ | ||
| with open('openedx/core/lib/tests/pickled_data/pickled_datetime.txt', 'rb') as fp: | ||
| val = zunpickle(fp.read()) | ||
| assert val < datetime.now(pytz.utc) |
There was a problem hiding this comment.
Did you verify that this test failed with the new python-dateutil version when using a pickle created with the version on master? Just making sure that this test case at least reproduces the problem we've already encountered.
There was a problem hiding this comment.
Yes, If I generate the pickle on python-dateutil==2.4.0 and run the test with python-dateutil==2.8.1 we get the exact same error as we got on production i.e.
AttributeError: 'tzlocal' object has no attribute '_hasdst'
This reverts commit 40878cd.
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
|
EdX Release Notice: This PR has been rolled back from the production environment. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
4 participants
Attempting this upgrade again since last time it was reverted due to cache unpickling problem.
Complete details here https://openedx.atlassian.net/browse/BOM-2245?focusedCommentId=525883
This time we are going to clear the cache and blockstore configuration when this gets deployed to production using command