-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat!: remove all access to Old Mongo courses #29848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jmyatt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
81779e3 to
7186b1c
Compare
a653c74 to
c06d2df
Compare
c06d2df to
beae942
Compare
178dd91 to
21fd0d2
Compare
Change has_access to deny 'load' support for Old Mongo courses. This is in service of dropping support for these ancient courses and removing legacy code that they rely on. DEPR-58
21fd0d2 to
3fad9d6
Compare
|
@mikix: Is there a timeline for when this is scheduled to merge? |
Heyo! Yes. We've been delaying, once I had shut off incoming enrollments, just to be a bit nicer to edx.org learners and give them a bit to finish the course. We are currently targeting landing this next Monday (April 4th), in time for Nutmeg. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
|
EdX Release Notice: This PR may have caused e2e tests to fail on Stage. If you're a member of the edX org, please visit #e2e-troubleshooting on Slack to help diagnose the cause of these failures. Otherwise, it is the reviewer's responsibility. E2E tests have failed. https://gocd.tools.edx.org/go/tab/pipeline/history/deploy_to_stage |
|
EdX Release Notice: This PR has been deployed to the production environment. |
Change has_access to deny 'load' support for Old Mongo courses.
This is in service of dropping support for these ancient courses and removing legacy code that they rely on.
DEPR-58
DEPR-123
Here's a screenshot of what the dashboard looks like after this change. You can see both the error message we show when you try to go to an Old Mongo course (you get redirected to dashboard with this mesage). And you can see how an Old Mongo course card shows up - it's still there, but without any links.
