Skip to content

Conversation

@mikix
Copy link
Contributor

@mikix mikix commented Jan 31, 2022

Change has_access to deny 'load' support for Old Mongo courses.

This is in service of dropping support for these ancient courses and removing legacy code that they rely on.

DEPR-58
DEPR-123

Here's a screenshot of what the dashboard looks like after this change. You can see both the error message we show when you try to go to an Old Mongo course (you get redirected to dashboard with this mesage). And you can see how an Old Mongo course card shows up - it's still there, but without any links.
Screenshot from 2022-02-17 11-13-15

Copy link
Contributor

@jmyatt jmyatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikix mikix force-pushed the mikix/remove-old-mongo-access branch 12 times, most recently from 81779e3 to 7186b1c Compare February 11, 2022 18:57
@mikix mikix force-pushed the mikix/remove-old-mongo-access branch 3 times, most recently from a653c74 to c06d2df Compare February 17, 2022 16:30
@mikix mikix force-pushed the mikix/remove-old-mongo-access branch from c06d2df to beae942 Compare February 17, 2022 17:46
@mikix mikix force-pushed the mikix/remove-old-mongo-access branch 2 times, most recently from 178dd91 to 21fd0d2 Compare March 1, 2022 15:23
Change has_access to deny 'load' support for Old Mongo courses.

This is in service of dropping support for these ancient
courses and removing legacy code that they rely on.

DEPR-58
@ormsbee
Copy link
Contributor

ormsbee commented Mar 29, 2022

@mikix: Is there a timeline for when this is scheduled to merge?

@mikix
Copy link
Contributor Author

mikix commented Mar 29, 2022

@mikix: Is there a timeline for when this is scheduled to merge?

Heyo! Yes. We've been delaying, once I had shut off incoming enrollments, just to be a bit nicer to edx.org learners and give them a bit to finish the course.

We are currently targeting landing this next Monday (April 4th), in time for Nutmeg.

@mikix mikix merged commit 436fc52 into master Apr 4, 2022
@mikix mikix deleted the mikix/remove-old-mongo-access branch April 4, 2022 13:55
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR may have caused e2e tests to fail on Stage. If you're a member of the edX org, please visit #e2e-troubleshooting on Slack to help diagnose the cause of these failures. Otherwise, it is the reviewer's responsibility. E2E tests have failed. https://gocd.tools.edx.org/go/tab/pipeline/history/deploy_to_stage

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants