Skip to content

feat: Add support for zip files to course and library import code#34191

Merged
Agrendalath merged 3 commits intoopenedx:masterfrom
open-craft:feat/poc-zip-import
Mar 8, 2024
Merged

feat: Add support for zip files to course and library import code#34191
Agrendalath merged 3 commits intoopenedx:masterfrom
open-craft:feat/poc-zip-import

Conversation

@xitij2000
Copy link
Contributor

@xitij2000 xitij2000 commented Feb 6, 2024 •
edited
Loading

Description

Adds support for zip files for course import.

Supporting information

Continuation of #33561

Testing instructions

See: #33561

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 6, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Feb 6, 2024 •
edited
Loading

Thanks for the pull request, @xitij2000! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@xitij2000 xitij2000 force-pushed the feat/poc-zip-import branch 8 times, most recently from 8ae63b6 to 694745e Compare February 8, 2024 11:06
@xitij2000 xitij2000 force-pushed the feat/poc-zip-import branch 5 times, most recently from bfdb2e0 to a31edba Compare February 20, 2024 18:21
@xitij2000 xitij2000 marked this pull request as ready for review February 21, 2024 07:21
@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Feb 21, 2024
Agrendalath
Agrendalath approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@Agrendalath Agrendalath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: checked importing the course and verified potential attack vectors
  • I read through the code
  • I checked for accessibility issues: n/a
  • Includes documentation: n/a
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository: n/a

@xitij2000 xitij2000 force-pushed the feat/poc-zip-import branch from a31edba to a3895eb Compare March 6, 2024 09:42
@Agrendalath Agrendalath merged commit c3c0adf into openedx:master Mar 8, 2024
@Agrendalath Agrendalath deleted the feat/poc-zip-import branch March 8, 2024 17:51
@Agrendalath Agrendalath mentioned this pull request Mar 8, 2024
Closed
@edx-pipeline-bot
Copy link
Contributor

edx-pipeline-bot commented Mar 8, 2024

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@openedx-webhooks
Copy link

openedx-webhooks commented Mar 8, 2024

@xitij2000 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

edx-pipeline-bot commented Mar 8, 2024

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

edx-pipeline-bot commented Mar 8, 2024

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

edx-pipeline-bot commented Mar 8, 2024

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

edx-pipeline-bot commented Mar 8, 2024

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

edx-pipeline-bot commented Mar 8, 2024

2U Release Notice: This PR has been deployed to the edX production environment.

yusuf-musleh added a commit to open-craft/taxonomy-sample-data that referenced this pull request Mar 19, 2024
@yusuf-musleh
fix: Match upstream extract_tar -> extract_archive
9dfd9a8 
This fixes a breaking change introduced in openedx/openedx-platform#34191
@yusuf-musleh yusuf-musleh mentioned this pull request Mar 19, 2024
Merged
bradenmacdonald pushed a commit to open-craft/taxonomy-sample-data that referenced this pull request Mar 20, 2024
@yusuf-musleh
fix: Match upstream extract_tar -> extract_archive (#7)
6217f81 
This fixes a breaking change introduced in openedx/openedx-platform#34191
@johanseto johanseto mentioned this pull request May 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Agrendalath Agrendalath Agrendalath approved these changes

Assignees

No one assigned

Labels

open-source-contribution PR author is not from Axim or 2U waiting for eng review PR is ready for review. Review and merge it, or suggest changes.

Projects

Contributions
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@xitij2000 @openedx-webhooks @edx-pipeline-bot @Agrendalath @mphilbrick211 @rodfersou