build: add support for Python 3.12#37160
Conversation
|
Thanks for the pull request, @UsamaSadiq! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
84f911e to
c29941a
Compare
1004138 to
6f01193
Compare
214cf14 to
9d364a6
Compare
9d364a6 to
bf70b59
Compare
76bf0a8 to
8df7495
Compare
feanil
left a comment
There was a problem hiding this comment.
Changes generally look good, just a couple of things to cleanup and then this will be good to land!
|
@feanil @UsamaSadiq Looks like we're almost able to merge this. Any objections to backporting to Ulmo once it's in, so that Ulmo can simultaneously support both 3.11 and 3.12? |
Yes, this PR will be ready to be merged soon. There shouldn't be any issue backporting it since it is only a support PR. |
|
@UsamaSadiq I think I'm just waiting for you to address the few comments I had and then I can approve this to merge. Feel free to re-tag me for review when this PR is ready again. |
@feanil I was away for 2 weeks. Will update this PR within this week, IA. |
fc733b2 to
bdaa46a
Compare
|
@UsamaSadiq Shouldn't we pass the test cases first? |
|
@farhan CI was green at first but tests failed after I made some changes. I'll fix the tests and then tag for review again.
|
|
@feanil Let's have this PR merged as soon as possible to avoid the need of rebasing or resolving conflicts again. |
openedx/openedx-platform#37160 is merged to unblock Python 3.12 in edx-platform master
* build: add support for Python 3.12
* build: add support for Python 3.12
* build: add support for Python 3.12
* build: add support for Python 3.12
* build: add support for Python 3.12
Description
Python 3.12under the issue Drop Python 3.8 & Add Support for Python 3.12 #35457