Skip to content

build: add support for Python 3.12#37160

Merged
UsamaSadiq merged 6 commits intomasterfrom
add-python312-support
Dec 15, 2025
Merged

build: add support for Python 3.12#37160
UsamaSadiq merged 6 commits intomasterfrom
add-python312-support

Conversation

@UsamaSadiq
Copy link
Member

Description

@openedx-webhooks
Copy link

openedx-webhooks commented Aug 11, 2025

Thanks for the pull request, @UsamaSadiq!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Aug 11, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Aug 11, 2025
@UsamaSadiq UsamaSadiq force-pushed the add-python312-support branch from 84f911e to c29941a Compare August 11, 2025 08:07
@UsamaSadiq UsamaSadiq force-pushed the add-python312-support branch from 1004138 to 6f01193 Compare August 11, 2025 12:18
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Aug 14, 2025
@UsamaSadiq UsamaSadiq closed this Oct 10, 2025
@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions Oct 10, 2025
@UsamaSadiq UsamaSadiq reopened this Oct 10, 2025
@UsamaSadiq UsamaSadiq force-pushed the add-python312-support branch from 214cf14 to 9d364a6 Compare October 10, 2025 16:45
@UsamaSadiq UsamaSadiq force-pushed the add-python312-support branch from 9d364a6 to bf70b59 Compare October 15, 2025 02:29
@UsamaSadiq UsamaSadiq marked this pull request as ready for review October 15, 2025 17:03
@UsamaSadiq UsamaSadiq requested a review from a team as a code owner October 15, 2025 17:03
@UsamaSadiq UsamaSadiq added the hacktoberfest-accepted Issue accepted for hacktoberfest participants label Oct 15, 2025
@UsamaSadiq UsamaSadiq moved this from Done to Ready for Review in Contributions Oct 15, 2025
@UsamaSadiq UsamaSadiq force-pushed the add-python312-support branch from 76bf0a8 to 8df7495 Compare October 15, 2025 18:10
@UsamaSadiq UsamaSadiq requested review from awais786 and feanil October 15, 2025 18:26
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes generally look good, just a couple of things to cleanup and then this will be good to land!

@kdmccormick
Copy link
Member

@feanil @UsamaSadiq Looks like we're almost able to merge this. Any objections to backporting to Ulmo once it's in, so that Ulmo can simultaneously support both 3.11 and 3.12?

@UsamaSadiq
Copy link
Member Author

@feanil @UsamaSadiq Looks like we're almost able to merge this. Any objections to backporting to Ulmo once it's in, so that Ulmo can simultaneously support both 3.11 and 3.12?

Yes, this PR will be ready to be merged soon. There shouldn't be any issue backporting it since it is only a support PR.

@feanil
Copy link
Contributor

feanil commented Nov 6, 2025

@UsamaSadiq I think I'm just waiting for you to address the few comments I had and then I can approve this to merge. Feel free to re-tag me for review when this PR is ready again.

@mphilbrick211 mphilbrick211 moved this from Ready for Review to In Eng Review in Contributions Nov 13, 2025
@UsamaSadiq
Copy link
Member Author

@UsamaSadiq I think I'm just waiting for you to address the few comments I had and then I can approve this to merge. Feel free to re-tag me for review when this PR is ready again.

@feanil I was away for 2 weeks. Will update this PR within this week, IA.

@UsamaSadiq UsamaSadiq moved this from In review to In progress in Usama Open Source Tracker Dec 4, 2025
@UsamaSadiq UsamaSadiq force-pushed the add-python312-support branch from fc733b2 to bdaa46a Compare December 4, 2025 02:16
@farhan
Copy link
Contributor

farhan commented Dec 4, 2025

@UsamaSadiq Shouldn't we pass the test cases first?

@UsamaSadiq
Copy link
Member Author

@farhan CI was green at first but tests failed after I made some changes. I'll fix the tests and then tag for review again.

@UsamaSadiq Shouldn't we pass the test cases first?

@UsamaSadiq
Copy link
Member Author

@feanil edx-submissions version bump ( XQueue DEPR related changes ) was causing the test failures. I've reverted the package version bump from this PR for now. PR #37528 has the fix for the related test failure. I'll add a version constraint in the repository in a follow up PR which will be removed by the above mentioned PR to handle this as requirements upgrade PR is also failing tests due to the new package version.

Let's have this PR merged as soon as possible to avoid the need of rebasing or resolving conflicts again.

@UsamaSadiq UsamaSadiq requested a review from feanil December 13, 2025 13:51
@UsamaSadiq UsamaSadiq merged commit e1747f3 into master Dec 15, 2025
97 of 108 checks passed
@UsamaSadiq UsamaSadiq deleted the add-python312-support branch December 15, 2025 07:12
@github-project-automation github-project-automation bot moved this from In Eng Review to Done in Contributions Dec 15, 2025
@github-project-automation github-project-automation bot moved this from In progress to Done in Usama Open Source Tracker Dec 15, 2025
blarghmatey added a commit to mitodl/ol-infrastructure that referenced this pull request Dec 15, 2025
openedx/openedx-platform#37160 is merged to unblock Python 3.12 in
edx-platform master
UsamaSadiq added a commit to UsamaSadiq/edx-platform that referenced this pull request Dec 18, 2025
* build: add support for Python 3.12
UsamaSadiq added a commit to UsamaSadiq/edx-platform that referenced this pull request Dec 18, 2025
* build: add support for Python 3.12
UsamaSadiq added a commit to UsamaSadiq/edx-platform that referenced this pull request Dec 18, 2025
* build: add support for Python 3.12
UsamaSadiq added a commit to UsamaSadiq/edx-platform that referenced this pull request Dec 18, 2025
* build: add support for Python 3.12
mraman-2U pushed a commit to mraman-2U/edx-platform that referenced this pull request Dec 24, 2025
* build: add support for Python 3.12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). hacktoberfest-accepted Issue accepted for hacktoberfest participants open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants