fix Remove prerequisites and ocw_links from course_about.html #37480
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @filippovskii09! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
| % if pre_requisite_courses: | ||
| <% prc_target = reverse('about_course', args=[str(pre_requisite_courses[0]['key'])]) %> | ||
| <li class="prerequisite-course important-dates-item"> | ||
| <span class="icon fa fa-list-ul" aria-hidden="true"></span> | ||
| <p class="important-dates-item-title">${_("Prerequisites")}</p> | ||
| ## Multiple pre-requisite courses are not supported on frontend that's why we are pulling first element | ||
| <span class="important-dates-item-text pre-requisite"><a href="${prc_target}">${pre_requisite_courses[0]['display']}</a></span> | ||
| <p class="tip"> | ||
| ${Text(_("You must successfully complete {link_start}{prc_display}{link_end} before you begin this course.")).format( | ||
| link_start=HTML('<a href="{}">').format(prc_target), | ||
| link_end=HTML('</a>'), | ||
| prc_display=pre_requisite_courses[0]['display'], | ||
| )} | ||
| </p> | ||
| </li> | ||
| % endif |
There was a problem hiding this comment.
I think this section should be left, we plan to remove only the prerequisites and ocw_links sections
There was a problem hiding this comment.
I returned the necessary section
mphilbrick211
added
the
needs test run
mphilbrick211
moved this from Needs Triage
to Needs Tests Run or CLA Signed
in Contributions
|
@filippovskii09 I've added you to the openedx-triage team as you are covered under an entity CLA. This will mean that tests will run automatically when you submit a pull request in the future. Please look for an invitation in your email and accept it. |
e0d
removed
the
needs test run
mphilbrick211
moved this from Needs Tests Run or CLA Signed
to Waiting on Author
in Contributions
@e0d the letter arrived, I accepted it, thank you) |
filippovskii09
added
the
create-sandbox
|
Sandbox deployment failed 💥 |
6 participants
Description
Removed
prerequisitesandocw_linksfrom course_about.html templateSupporting information
We currently have [DEPR]: Deprecation of Prerequisites and OCW Links sections whose main purpose is to inform consumers and operators of OpenEdx intention to remove prerequisites and ocw_links from the
course_about.htmltemplate due to the fact that there is no backend logic associated with these fields.Testing instructions
Please provide detailed step-by-step instructions for testing this change.
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
Include anything else that will help reviewers and consumers understand the change.