refactor: Move upload/delete transcript int video_config service #37793
Conversation
farhan
added
the
create-sandbox
|
Sandbox deployment successful 🚀 |
feanil
left a comment
feanil
left a comment
There was a problem hiding this comment.
Changes look good, assuming there is no major changes needed as a part of fixing the conflict with master, I think this is good to merge without another review.
| elif service_name == 'error_tracker': | ||
| return make_error_tracker() | ||
| elif service_name == 'video_config': | ||
| # Import here to avoid circular dependency |
There was a problem hiding this comment.
Not a big deal but it would be nice to note what the circular dependency is in the comment here.
There was a problem hiding this comment.
Let's do all the extraction part and clean the code from platform and then we will review the circular imports in following ticket.
This moves edx-platform-specific logic out of the VideoBlock, in preparation for the VideoBlock extraction: #36282
farhan
force-pushed
the
farhan/upload-delete-transcript
branch
from
62aef19 to
3c9e1a9
Compare
|
Sandbox deployment failed 💥 |
|
Sandbox deployment successful 🚀 |
Description
This moves edx-platform-specific logic out of the VideoBlock, in preparation for the VideoBlock extraction:
#36282
Testing instructions
Go to studio, and in a course, add a transcript, and delete it.
Do the same in a v2 library.
This is a duplicate PR of this PR, further notes can be found on it.