fix: catch json errors on empty responses from ralph #461
Conversation
|
Thanks for the pull request, @Ian2012! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
openedx-webhooks
added
the
open-source-contribution
Ian2012
force-pushed
the
cag/duplicated-ids
branch
2 times, most recently
from
0d8329c
to
c650d4a
Compare
| @patch('event_routing_backends.utils.xapi_lrs_client.logger') | ||
| def test_duplicate_xapi_event_id_json(self, mocked_logger): | ||
| """ | ||
| Test that when we receive a 409 response when inserting an XAPI statement |
There was a problem hiding this comment.
These aren't 409s are they?
| try: | ||
| response = self.lrs_client.save_statements(statement_data) | ||
| except JSONDecodeError: | ||
| logger.warning(f"Events already in LRS: {statement_data}") |
There was a problem hiding this comment.
This error can be triggered for any JSON issues. Since we have no ability to tell the difference between a real error and a spurious 204, maybe the message can be "JSON Decode Error, this may indicate that all sent events are already stored."?
Description: Closes #460
JIRA: Link to JIRA ticket
Dependencies: dependencies on other outstanding PRs, issues, etc.
Merge deadline: List merge deadline (if any)
Installation instructions: List any non-trivial installation
instructions.
Testing instructions:
Merge checklist:
Post merge:
finished.
Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.