Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fixes invalid members being added to groups #1373

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

katrinan029
Copy link
Contributor

Description

Fixes bug that adds invalid org members to a group in the create group modal.

https://2u-internal.atlassian.net/browse/ENT-9858

Screen.Recording.2025-01-06.at.2.02.27.PM.mov

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@f5435c9). Learn more about missing BASE report.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1373   +/-   ##
=========================================
  Coverage          ?   85.80%           
=========================================
  Files             ?      610           
  Lines             ?    13430           
  Branches          ?     2785           
=========================================
  Hits              ?    11523           
  Misses            ?     1837           
  Partials          ?       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@katrinan029 katrinan029 merged commit 0847890 into master Jan 7, 2025
4 checks passed
@katrinan029 katrinan029 deleted the knguyen2/ent-9858 branch January 7, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants