-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dropped] Add “Unit” to filter-by-type dropdown #1639
Comments
@sdaitzman It seems weird to me to have both a tab and a filter option in the dropdown. I'd suggest one or the other. |
Though the dropdown does have the advantage that you could choose "units and subsections" for example, if they were both in the type filter, which you can't do with tabs. Not sure if we care. |
@bradenmacdonald agreed that it's a bit strange-- I feel good dropping this. We'll eventually need to implicitly filter to just units for e.g. adding a unit to a subsection, but it makes sense to rely on the tab bar for browsing only sections/subsections/units. |
We should discuss whether we want to show units in the "filter by type" dropdown, and drop this story if not.
Spec
In Scope
Not in scope
The text was updated successfully, but these errors were encountered: