Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dropped] Add “Unit” to filter-by-type dropdown #1639

Closed
sdaitzman opened this issue Jan 28, 2025 · 3 comments
Closed

[dropped] Add “Unit” to filter-by-type dropdown #1639

sdaitzman opened this issue Jan 28, 2025 · 3 comments

Comments

@sdaitzman
Copy link

sdaitzman commented Jan 28, 2025

We should discuss whether we want to show units in the "filter by type" dropdown, and drop this story if not.

Spec

  • Users can filter by "unit" type

In Scope

  • Add "unit" to type dropdown

Not in scope

  • Separate unit tab at library level
  • Any unit subtypes
@bradenmacdonald
Copy link
Contributor

@sdaitzman It seems weird to me to have both a tab and a filter option in the dropdown. I'd suggest one or the other.

@bradenmacdonald
Copy link
Contributor

Though the dropdown does have the advantage that you could choose "units and subsections" for example, if they were both in the type filter, which you can't do with tabs. Not sure if we care.

@sdaitzman
Copy link
Author

@bradenmacdonald agreed that it's a bit strange-- I feel good dropping this. We'll eventually need to implicitly filter to just units for e.g. adding a unit to a subsection, but it makes sense to rely on the tab bar for browsing only sections/subsections/units.

@github-project-automation github-project-automation bot moved this from In grooming to Done in Libraries Overhaul Feb 7, 2025
@sdaitzman sdaitzman changed the title Add “Unit” to filter-by-type dropdown [dropped] Add “Unit” to filter-by-type dropdown Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants