Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to deprecated frontend-lib-content-components repo #209

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

bradenmacdonald
Copy link
Contributor

In openedx/frontend-app-authoring#1208 we merged frontend-lib-content-components into frontend-app-course-authoring, and there is no remaining usage of frontend-lib-content-components so we will soon be archiving that repo.

@OmarIthawi noticed that there is a reference to that deprecated frontend-lib-content-components repo in this project. It's unclear to me what it was supposed to be doing, so I'm just removing it for now. As far as I can tell, this app does not actually relate to frontend-lib-content-components, and there are no references to it in the code.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 29, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @bradenmacdonald!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/committers-frontend. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.26%. Comparing base (1e1f269) to head (9b2220b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #209   +/-   ##
=======================================
  Coverage   83.26%   83.26%           
=======================================
  Files          47       47           
  Lines         693      693           
  Branches      135      135           
=======================================
  Hits          577      577           
  Misses        116      116           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@OmarIthawi OmarIthawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's my code and I think it's a copy/paste leftover. Thanks @bradenmacdonald for the cleanup.

@bradenmacdonald
Copy link
Contributor Author

@kdmccormick Would you mind giving a +1 on this tiny cleanup PR so I can hit merge? I got +1 from @OmarIthawi but his approval doesn't count as official on this repo.

Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Is there anything that needs to be done to move the translations over from the old repo to the new one in Transifex? Or are the strings shared across all frontend repos?

@bradenmacdonald bradenmacdonald merged commit 7dc08c0 into master Sep 3, 2024
7 checks passed
@bradenmacdonald bradenmacdonald deleted the braden/remove-flcc-reference branch September 3, 2024 17:00
@openedx-webhooks
Copy link

@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants