-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include paragonMessages
in MFE initialization
#340
Comments
@PKulkoRaccoonGang @adamstankiewicz Coming late to the party, would you mind updating the Makefile to keep atlas pull in sync with index.js changes? If you're new to OEP-58 and atlas please look at the following PR openedx/frontend-template-application#622 I've done few PRs already:
But if you're still making those changes, it would be grade to bundle the I plan to continue on the other repos as well this week. |
@OmarIthawi Thanks for the raising this! I have not had a chance to look at OEP-58 yet. I approved/merged your two linked PRs mentioned above. [clarification] Do you / the FC-0012 project intend to implement the changes to include Paragon in the atlas pull across the remainder of the MFEs, or is this something you'd expect to be prioritized with the Paragon Working Group? Regardless, filing an issue for it in the Paragon GitHub, if one doesn't already exist, might be helpful to track it from the Paragon Working Group's perspective. |
Hopefully we'll get done with the OEP-58 work soon so you all engineers can use it transparently and use the docs like other complete features. We've started few months ago and we're almost done.
I'll work on adding the fixes, it's a minor patch anyway because atlas integration is already added in all the MFEs that I'm aware of. Code reviews would be very helpful, because we had an issue of triaging PRs with different owners. Would that be something you'd be interested to help with?
Where can add the issue? Do you mean in the paragon repo itself https://github.com/openedx/paragon/issues ? |
[next steps] Check in on frontend-app-ora-grading, too. |
@adamstankiewicz I've updated all the repos Makefile. So there's no need to add an issue. |
@edx/paragon
was recently upgraded to v20 in this MFE. v20 added a dependency onreact-intl
due to Paragon now shipping with already-translated English messages for its components.Per the release notes, Paragon v20 now exposes a
paragonMessages
array containing the native translations for Paragon components but theparagonMessages
are not yet passed to@edx/frontend-platform
via theinitialize
function for this MFE.Looks like importing and re-exporting
paragonMessages
insrc/i18n/index.js
(source) would do the trick 😃Tasks
The text was updated successfully, but these errors were encountered: