Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include paragonMessages in MFE initialization #340

Open
2 tasks
adamstankiewicz opened this issue Jun 27, 2023 · 6 comments
Open
2 tasks

Include paragonMessages in MFE initialization #340

adamstankiewicz opened this issue Jun 27, 2023 · 6 comments
Assignees

Comments

@adamstankiewicz
Copy link
Member

adamstankiewicz commented Jun 27, 2023

@edx/paragon was recently upgraded to v20 in this MFE. v20 added a dependency on react-intl due to Paragon now shipping with already-translated English messages for its components.

Per the release notes, Paragon v20 now exposes a paragonMessages array containing the native translations for Paragon components but the paragonMessages are not yet passed to @edx/frontend-platform via the initialize function for this MFE.

Looks like importing and re-exporting paragonMessages in src/i18n/index.js(source) would do the trick 😃

Tasks

@PKulkoRaccoonGang
Copy link
Contributor

PKulkoRaccoonGang commented Jul 6, 2023

@OmarIthawi
Copy link
Member

@PKulkoRaccoonGang @adamstankiewicz Coming late to the party, would you mind updating the Makefile to keep atlas pull in sync with index.js changes?

If you're new to OEP-58 and atlas please look at the following PR openedx/frontend-template-application#622

I've done few PRs already:

But if you're still making those changes, it would be grade to bundle the Makefile as well.

I plan to continue on the other repos as well this week.

@adamstankiewicz
Copy link
Member Author

@OmarIthawi Thanks for the raising this! I have not had a chance to look at OEP-58 yet. I approved/merged your two linked PRs mentioned above.

[clarification] Do you / the FC-0012 project intend to implement the changes to include Paragon in the atlas pull across the remainder of the MFEs, or is this something you'd expect to be prioritized with the Paragon Working Group?

Regardless, filing an issue for it in the Paragon GitHub, if one doesn't already exist, might be helpful to track it from the Paragon Working Group's perspective.

@OmarIthawi
Copy link
Member

OmarIthawi commented Jul 23, 2023

@OmarIthawi Thanks for the raising this! I have not had a chance to look at OEP-58 yet. I approved/merged your two linked PRs mentioned above.

Hopefully we'll get done with the OEP-58 work soon so you all engineers can use it transparently and use the docs like other complete features. We've started few months ago and we're almost done.

[clarification] Do you / the FC-0012 project intend to implement the changes to include Paragon in the atlas pull across the remainder of the MFEs, or is this something you'd expect to be prioritized with the Paragon Working Group?

I'll work on adding the fixes, it's a minor patch anyway because atlas integration is already added in all the MFEs that I'm aware of. Code reviews would be very helpful, because we had an issue of triaging PRs with different owners. Would that be something you'd be interested to help with?

Regardless, filing an issue for it in the Paragon GitHub, if one doesn't already exist, might be helpful to track it from the Paragon Working Group's perspective.

Where can add the issue? Do you mean in the paragon repo itself https://github.com/openedx/paragon/issues ?

@PKulkoRaccoonGang PKulkoRaccoonGang moved this from In review to Done in Paragon Working Group Jul 23, 2023
@adamstankiewicz
Copy link
Member Author

adamstankiewicz commented Jul 24, 2023

[next steps] Check in on frontend-app-ora-grading, too.

@OmarIthawi
Copy link
Member

@adamstankiewicz I've updated all the repos Makefile. So there's no need to add an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Status: Done
Development

No branches or pull requests

3 participants