Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix rows counter in the Edit Grade modal window #389

Open
wants to merge 1 commit into
base: open-release/quince.master
Choose a base branch
from

Conversation

Lunyachek
Copy link
Contributor

This is backport from master - #310

TL;DR - The problem was in the rows counter in the Edit Grades modal window. First digit - number of lines excluding the last line with the form. Second digit - grades data. And our proposal is to include last row with form to common counting

Снимок экрана 2023-02-10 в 15 25 06

What changed?

Снимок экрана 2023-02-10 в 15 42 01

FYI: @openedx/content-aurora

@Lunyachek Lunyachek requested a review from a team as a code owner April 4, 2024 20:45
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 4, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Apr 4, 2024

Thanks for the pull request, @Lunyachek!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @farhaanbukhsh. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.98%. Comparing base (ba9fb37) to head (777e55e).
Report is 3 commits behind head on open-release/quince.master.

Additional details and impacted files
@@                     Coverage Diff                     @@
##           open-release/quince.master     #389   +/-   ##
===========================================================
  Coverage                       94.98%   94.98%           
===========================================================
  Files                             140      140           
  Lines                            1356     1357    +1     
  Branches                          264      264           
===========================================================
+ Hits                             1288     1289    +1     
  Misses                             60       60           
  Partials                            8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 removed the request for review from a team April 5, 2024 00:56
@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Apr 5, 2024
@mphilbrick211
Copy link

Hi @farhaanbukhsh! The master for this PR has been merged, so this one should be good-to-go. Thanks!

@farhaanbukhsh
Copy link
Member

@mphilbrick211 sure will merge this after testing :)

Copy link
Member

@farhaanbukhsh farhaanbukhsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Lunyachek can you have look at the comment and test it. Thanks a lot for the PR. Let me know if you need more clarification.

Comment on lines +23 to +30
const tableData = [
...data,
{
adjustedGrade: <AdjustedGradeInput />,
date: formatDateForDisplay(new Date()),
reason: <ReasonInput />,
},
];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we put a check on the data something like

Suggested change
const tableData = [
...data,
{
adjustedGrade: <AdjustedGradeInput />,
date: formatDateForDisplay(new Date()),
reason: <ReasonInput />,
},
];
const tableData = data ? [
...data,
{
adjustedGrade: <AdjustedGradeInput />,
date: formatDateForDisplay(new Date()),
reason: <ReasonInput />,
},
] : [];

While testing I landed up on error when data was undefined and this happened multiple times mostly I guess when the states were getting updated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peek 2024-08-02 01-09

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should backport 4e9270a

@farhaanbukhsh
Copy link
Member

Hi @farhaanbukhsh! The master for this PR has been merged, so this one should be good-to-go. Thanks!

hey @mphilbrick211 I have reviewed the PR and added few suggestion and changes

@mphilbrick211
Copy link

Hi @farhaanbukhsh! The master for this PR has been merged, so this one should be good-to-go. Thanks!

hey @mphilbrick211 I have reviewed the PR and added few suggestion and changes

Thanks, @farhaanbukhsh!

Flagging this for you, @Lunyachek!

@farhaanbukhsh
Copy link
Member

@Lunyachek can you please backport the additional commit so that we can safely merge the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U
Projects
Status: In progress
Status: In Eng Review
Development

Successfully merging this pull request may close these issues.

4 participants