Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [FC-0065] display course credentials on VC page #469

Merged

Conversation

kyrylo-kh
Copy link
Contributor

Description:
Display course credentials along with program credentials on the Verifiable Credentials tab
image

Related PR's:

@openedx-webhooks
Copy link

openedx-webhooks commented Jan 2, 2025

Thanks for the pull request, @kyrylo-kh!

This repository is currently maintained by @2U-aperture.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 91.89189% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.01%. Comparing base (6816a17) to head (1a37357).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...c/components/CertificatesList/CertificatesList.jsx 88.46% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #469      +/-   ##
==========================================
+ Coverage   73.25%   74.01%   +0.76%     
==========================================
  Files          28       28              
  Lines         415      431      +16     
  Branches       89      100      +11     
==========================================
+ Hits          304      319      +15     
- Misses        110      111       +1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyrylo-kh kyrylo-kh force-pushed the feat/display-course-credentials branch from c6d3174 to 140ec21 Compare January 2, 2025 11:19
@kyrylo-kh kyrylo-kh marked this pull request as ready for review January 15, 2025 15:25
@e0d
Copy link
Contributor

e0d commented Jan 15, 2025

@kyrylo-kh can you resolve the conflicts when you have a moment.

Copy link
Member

@deborahgu deborahgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, although I have one small request, nonblocking. One more aperture person is probably going to look as well.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@jsnwesson jsnwesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from some comments about dependencies and a string message, this looks good to me!

@kyrylo-kh kyrylo-kh force-pushed the feat/display-course-credentials branch 2 times, most recently from 4f0a0ea to 46049a6 Compare January 27, 2025 09:30
@deborahgu
Copy link
Member

looks good to me.

@kyrylo-kh kyrylo-kh force-pushed the feat/display-course-credentials branch from 46049a6 to 68d2cfd Compare January 28, 2025 09:14
@GlugovGrGlib GlugovGrGlib self-requested a review February 11, 2025 12:57
@GlugovGrGlib GlugovGrGlib added the FC Relates to an Axim Funded Contribution project label Feb 11, 2025
@GlugovGrGlib GlugovGrGlib changed the title feat: display course credentials on VC page feat: [FC-0065] display course credentials on VC page Feb 12, 2025
Copy link
Member

@GlugovGrGlib GlugovGrGlib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove webpack.dev-tutor.config.js and this PR is ready to be merged. Thanks!

webpack.dev-tutor.config.js Outdated Show resolved Hide resolved
@kyrylo-kh kyrylo-kh force-pushed the feat/display-course-credentials branch from 68d2cfd to 1c2cee2 Compare February 13, 2025 09:32
@kyrylo-kh kyrylo-kh force-pushed the feat/display-course-credentials branch from 1c2cee2 to 1a37357 Compare February 13, 2025 09:37
@deborahgu deborahgu merged commit 5f3585f into openedx:master Feb 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants