-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [FC-0065] display course credentials on VC page #469
feat: [FC-0065] display course credentials on VC page #469
Conversation
Thanks for the pull request, @kyrylo-kh! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #469 +/- ##
==========================================
+ Coverage 73.25% 74.01% +0.76%
==========================================
Files 28 28
Lines 415 431 +16
Branches 89 100 +11
==========================================
+ Hits 304 319 +15
- Misses 110 111 +1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
c6d3174
to
140ec21
Compare
@kyrylo-kh can you resolve the conflicts when you have a moment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, although I have one small request, nonblocking. One more aperture person is probably going to look as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from some comments about dependencies and a string message, this looks good to me!
4f0a0ea
to
46049a6
Compare
looks good to me. |
46049a6
to
68d2cfd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove webpack.dev-tutor.config.js
and this PR is ready to be merged. Thanks!
68d2cfd
to
1c2cee2
Compare
1c2cee2
to
1a37357
Compare
Description:
![image](https://private-user-images.githubusercontent.com/59133933/399676701-f96e5627-fd58-46e4-a888-dda016a2cdab.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NDIyMDQsIm5iZiI6MTczOTY0MTkwNCwicGF0aCI6Ii81OTEzMzkzMy8zOTk2NzY3MDEtZjk2ZTU2MjctZmQ1OC00NmU0LWE4ODgtZGRhMDE2YTJjZGFiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDE3NTE0NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY4MmNiNzZhNjk0MTM3MjkxYjk4NWRiNzAyNzkzZGY1ODFkMTk5NTk1YjFhM2Q1M2UyMzcyNDQyODUxYmQ4MDImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.LC_vXq5BXYdwwM11UzqEMcaKaEIz6kxVrDnK1Okodl4)
Display course credentials along with program credentials on the Verifiable Credentials tab
Related PR's: