fix: updated react-redux peerDependency to resolve CI failure #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #557 +/- ##
=======================================
Coverage 83.08% 83.08%
=======================================
Files 40 40
Lines 1064 1064
Branches 194 194
=======================================
Hits 884 884
Misses 168 168
Partials 12 12 ☔ View full report in Codecov by Sentry. |
BilalQamar95
force-pushed
the
bilalqamar95/ci-fix
branch
from
00c8695
to
39513cb
Compare
abdullahwaheed
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
react-reduxpeerDependency was updated in #549 causing CI failure for its consumers. Since the public API (<Provider>,connect,useSelector/useDispatch) remains unchanged and for most use-cases applications using v7 would work with v8 (apart from some rare API likeconnectAdvancedwhich have been removed), peerDependency forreact-reduxwas updated in order to prevent any dependency issues for consumers.