fix: update build script to make it package properly #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
leangseu-edx
commented
Mar 21, 2024
•
leangseu-edx
commented
- update build script to make npm package find the transpiled files.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #48 +/- ##
=======================================
Coverage 96.53% 96.53%
=======================================
Files 10 10
Lines 173 173
Branches 35 35
=======================================
Hits 167 167
Misses 5 5
Partials 1 1 ☔ View full report in Codecov by Sentry. |
leangseu-edx
force-pushed
the
lk/update-package-build-script
branch
from
971de18
to
2122e24
Compare
leangseu-edx
changed the title
arbrandes
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Looks like we missed a couple of spots. Thanks @leangseu-edx! Approved, though I'll let Jason have final say.
jsnwesson
approved these changes
Mar 21, 2024
|
Thanks @leangseu-edx ! I was wondering about what would've been needed to get the package build, glad you thought of this too. |
|
🎉 This PR is included in version 1.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.