-
Notifications
You must be signed in to change notification settings - Fork 5
fix: Fix Upgrade Python Requirements #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix Upgrade Python Requirements #206
Conversation
|
Thanks for the pull request, @rodmgwgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
requirements/constraints.txt
Outdated
| click==8.3.0 | ||
| click==8.3.1 | ||
|
|
||
| # Latest version of wheel is requiring packaging==26.0, but other packages require packaging==25.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks likes the latest version of wheel (0.46.3) pins the packaging dependency equal to or greater than version 24.0, which leads me to believe this isn't the source of the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, in this case it seems that the issue is that packaging 26.0 was just released on Jan 21, and because of that, the dependency on wheel resolves to 26 now.
bmtcril
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but can you update the constraints.txt to include that the pin can be removed when the root issue is sorted out? We don't want to be on packaging 25 any longer than necessary since I think that version has a security issue.
It looks like the root cause is edx-api-doc-tools being unmaintained, so no requirements have been upgraded there in a long time and no release since last April. It pulls in the old version of drf-yasg that seems to be what's got packaging pinned. I'll look into trying to fix that today.
|
A better solution was done here: #207 (review) |
The automated "Upgrade Python Requirements" workflow was failing.
This was due to the latest version of the "wheel" package requiring "packaging==26.0", while several other packages require "packaging==25.0".
Merge checklist:
Check off if complete or not applicable: