Skip to content

Conversation

@rodmgwgu
Copy link
Contributor

The automated "Upgrade Python Requirements" workflow was failing.

This was due to the latest version of the "wheel" package requiring "packaging==26.0", while several other packages require "packaging==25.0".

  • Added a constrain to specify "packaging==25.0", this fixes the issue.
  • Ran "make upgrade" to apply the package upgrades.
  • Ran "make quality" and "make test" to confirm nothing breaks.

Merge checklist:
Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

@rodmgwgu rodmgwgu requested a review from bmtcril January 29, 2026 21:43
@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Jan 29, 2026
@openedx-webhooks
Copy link

Thanks for the pull request, @rodmgwgu!

This repository is currently maintained by @openedx/committers-openedx-authz.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

click==8.3.0
click==8.3.1

# Latest version of wheel is requiring packaging==26.0, but other packages require packaging==25.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks likes the latest version of wheel (0.46.3) pins the packaging dependency equal to or greater than version 24.0, which leads me to believe this isn't the source of the issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, in this case it seems that the issue is that packaging 26.0 was just released on Jan 21, and because of that, the dependency on wheel resolves to 26 now.

Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but can you update the constraints.txt to include that the pin can be removed when the root issue is sorted out? We don't want to be on packaging 25 any longer than necessary since I think that version has a security issue.

It looks like the root cause is edx-api-doc-tools being unmaintained, so no requirements have been upgraded there in a long time and no release since last April. It pulls in the old version of drf-yasg that seems to be what's got packaging pinned. I'll look into trying to fix that today.

@rodmgwgu
Copy link
Contributor Author

A better solution was done here: #207 (review)

@rodmgwgu rodmgwgu closed this Jan 30, 2026
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants